Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1882810: vsphere - local dns prepender not named with template #4220

Merged

Conversation

jcpowermac
Copy link
Contributor

Change the filename from 30-local-dns-prepender
to 30-local-dns-prepender.template

So the {{if}}{{end}} can be rendered.

Change the filename from 30-local-dns-prepender
to 30-local-dns-prepender.template

So the {{if}}{{end}} can be rendered.
@jcpowermac jcpowermac changed the title vsphere - local dns prepender not named with template Bug 1882810: vsphere - local dns prepender not named with template Sep 25, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: This pull request references Bugzilla bug 1882810, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1882810: vsphere - local dns prepender not named with template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
Copy link
Contributor Author

This is causing:

{{if: command not found
Sep 25 17:40:48 localhost nm-dispatcher[1683]: <13>Sep 25 17:40:48 root: NM local-dns-prepender triggered by ens192 up.
Sep 25 17:40:48 localhost nm-dispatcher[1683]: <13>Sep 25 17:40:48 root: NM local-dns-prepender: Checking if local DNS IP is the first entry in resolv.conf
Sep 25 17:40:48 localhost root[1758]: NM local-dns-prepender: Looking for '# Generated by NetworkManager' in /etc/resolv.conf to place 'nameserver 127.0.0.1'
Sep 25 17:40:48 localhost nm-dispatcher[1683]: <13>Sep 25 17:40:48 root: NM local-dns-prepender: Looking for '# Generated by NetworkManager' in /etc/resolv.conf to place 'nameserver 127.0.0.1'
Sep 25 17:40:48 localhost nm-dispatcher[1683]: /etc/NetworkManager/dispatcher.d/30-local-dns-prepender: line 18: {{end}}: command not found

And resolution failure durning bootstrap for api-int

@jcpowermac
Copy link
Contributor Author

/test e2e-vsphere-upi

/test e2e-vsphere

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@jcpowermac
Copy link
Contributor Author

CI cluster was being updated...try again:

/test e2e-vsphere-upi

/test e2e-vsphere

@jcpowermac
Copy link
Contributor Author

With my manual install got past bootstrap:

INFO Consuming Install Config from target directory
WARNING Found override for release image. Please be warned, this is not advised
INFO Obtaining RHCOS image file from 'https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.6/46.82.202009222340-0/x86_64/rhcos-46.82.202009222340-0-vmware.x86_64.ova?sha256=1e4c4bd1ef66973f2289a23e8f570309a93c209be4b354c1ab873c494fcad332'                                                                   
INFO Creating infrastructure resources...
INFO Waiting up to 20m0s for the Kubernetes API at https://api.jcallen.vmc.devcluster.openshift.com:6443...                                                         
INFO API v1.19.0+31bf081 up
INFO Waiting up to 30m0s for bootstrapping to complete...
INFO Destroying the bootstrap resources...

significantly faster than it has been.

@jcpowermac
Copy link
Contributor Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2020

@jcpowermac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc ef7e362 link /test e2e-crc
ci/prow/e2e-vsphere-upi ef7e362 link /test e2e-vsphere-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 527e3be into openshift:master Sep 26, 2020
@openshift-ci-robot
Copy link
Contributor

@jcpowermac: All pull requests linked via external trackers have merged:

Bugzilla bug 1882810 has been moved to the MODIFIED state.

In response to this:

Bug 1882810: vsphere - local dns prepender not named with template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants