Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1884691: types: allow manual cred mode for gcp and azure #4238

Merged
merged 1 commit into from Oct 9, 2020
Merged

Bug 1884691: types: allow manual cred mode for gcp and azure #4238

merged 1 commit into from Oct 9, 2020

Conversation

staebler
Copy link
Contributor

@staebler staebler commented Oct 2, 2020

Allow the user to set credentialsMode to "Manual" when installing on GCP and Azure. The cloud-credential-operator has support for the manual mode on those platforms.

@dgoodwin
Copy link
Contributor

dgoodwin commented Oct 2, 2020

I tested this, QE tested it, and Docs documented it. This happened as our README was out of date in the CCO repo showing unknown for these platforms, as I had not tested them at this time.

Investigating if we can beat code freeze today.
/cc @sdodson @abhinavdahiya

@staebler staebler force-pushed the manual_cred_mode_for_gcp_and_azure branch from 3434ca9 to b094e14 Compare October 2, 2020 15:34
dgoodwin
dgoodwin reviewed Oct 2, 2020
View reviewed changes
pkg/types/validation/installconfig_test.go
return c
}(),
expectedError: `^credentialsMode: Unsupported value: "Manual": supported values: "Mint", "Passthrough"$`,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this test stay if changed to a platform that isn't AWS, Azure, or GCP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, but it is already covered by the next test case below it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@staebler staebler changed the title types: allow manual cred mode for gcp and azure Bug 1884691: types: allow manual cred mode for gcp and azure Oct 2, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

@staebler: This pull request references Bugzilla bug 1884691, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1884691: types: allow manual cred mode for gcp and azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@staebler
Copy link
Contributor Author

staebler commented Oct 2, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@staebler: This pull request references Bugzilla bug 1884691, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@staebler
Copy link
Contributor Author

staebler commented Oct 2, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

@staebler: This pull request references Bugzilla bug 1884691, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgoodwin
Copy link
Contributor

dgoodwin commented Oct 2, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2020
@dgoodwin
Copy link
Contributor

dgoodwin commented Oct 2, 2020

Please hold until first 4.6.z, I've discovered the QE test plans did not go through this exact method, rather the old ConfigMap, and thus we're not 100% sure this is working until the test plans are updated and run.

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@abhinavdahiya
Copy link
Contributor

/hold cancel

as we are now open for 4.7

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 5, 2020
@staebler
types: allow manual cred mode for gcp and azure
c855848 
Allow the user to set `credentialsMode` to "Manual" when installing
on GCP and Azure. The cloud-credential-operator has support for
the manual mode on those platforms.
@staebler staebler force-pushed the manual_cred_mode_for_gcp_and_azure branch from b094e14 to c855848 Compare October 8, 2020 14:52
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2020
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020 •
edited

@staebler: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt c855848 link /test e2e-libvirt
ci/prow/e2e-crc c855848 link /test e2e-crc
ci/prow/e2e-aws-workers-rhel7 c855848 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f4bd8d9 into openshift:master Oct 9, 2020
@openshift-ci-robot
Copy link
Contributor

@staebler: All pull requests linked via external trackers have merged:

Bugzilla bug 1884691 has been moved to the MODIFIED state.

In response to this:

Bug 1884691: types: allow manual cred mode for gcp and azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin dgoodwin left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@staebler @dgoodwin @openshift-ci-robot @abhinavdahiya @openshift-bot @openshift-merge-robot