Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1889852: add new AWS regions #4288

Merged

Conversation

miabbott
Copy link
Member

There are RFEs requesting support for additional AWS regions:
ap-east-1, af-south-1, and eu-south-1

https://issues.redhat.com/browse/RFE-903
https://issues.redhat.com/browse/RFE-1267

This also bumps the boot image to a real RHCOS 4.7 image.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

@miabbott: This pull request references Bugzilla bug 1889852, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1889852: add new AWS regions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 21, 2020
@miabbott
Copy link
Member Author

cc: @cgwalters @ashcrow @katherinedube

@ashcrow
Copy link
Member

ashcrow commented Oct 21, 2020

I see eu-north-1 as well. Is that meant to be added?

@miabbott
Copy link
Member Author

I see eu-north-1 as well. Is that meant to be added?

We've already been publishing to that region since June 2019.

@ashcrow
Copy link
Member

ashcrow commented Oct 21, 2020

I see eu-north-1 as well. Is that meant to be added?

We've already been publishing to that region since June 2019.

You're right -- I misread the diff. 👍

@ashcrow
Copy link
Member

ashcrow commented Oct 21, 2020

The CRC failure looks like a flake but the verify-codegen looks like it needs an update in the PR.

@ashcrow
Copy link
Member

ashcrow commented Oct 21, 2020

Specifically go generate ./pkg/rhcos/ami.go

@ashcrow ashcrow self-requested a review October 21, 2020 14:50
@miabbott
Copy link
Member Author

Specifically go generate ./pkg/rhcos/ami.go

Thanks for the hint!

I want to coordinate this change with the installer team, before I make any additional changes. Going to ping @abhinavdahiya and @sdodson

There are RFEs requesting support for additional AWS regions:
ap-east-1, af-south-1, and eu-south-1

https://issues.redhat.com/browse/RFE-903
https://issues.redhat.com/browse/RFE-1267

This also bumps the boot image to a *real* RHCOS 4.7 image.
@miabbott
Copy link
Member Author

Pushed an amended commit with the regions added to pkg/rhcos/ami_regions.go

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ashcrow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@miabbott
Copy link
Member Author

miabbott commented Oct 22, 2020

e2e-crc appears to be failing during the build phase; not related to this PR

+ mkdir -p openshift-clients/linux openshift-clients/mac openshift-clients/windows
+ curl -L https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/4.6.0-ci/openshift-client-linux.tar.gz
+ tar -zx -C openshift-clients/linux oc
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0   360    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   360  100   360    0     0   4285      0 --:--:-- --:--:-- --:--:--  4235

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

e2e-ovirt is failing to get the API server fully up; but this PR doesn't affect oVirt.

@miabbott
Copy link
Member Author

For grins

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 22, 2020

@miabbott: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 3c087af link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 09b7021 into openshift:master Oct 22, 2020
@openshift-ci-robot
Copy link
Contributor

@miabbott: All pull requests linked via external trackers have merged:

Bugzilla bug 1889852 has been moved to the MODIFIED state.

In response to this:

Bug 1889852: add new AWS regions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants