Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-approvers: add staebler #4297

Merged
merged 1 commit into from Oct 23, 2020

Conversation

abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Oct 23, 2020

Make sure @staebler can help approve the PRs in case others (like me :P) are not available.

/assign @sdodson

@sdodson
Copy link
Member

sdodson commented Oct 23, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@abhinavdahiya
Copy link
Contributor Author

cc @staebler

@sdodson
Copy link
Member

sdodson commented Oct 23, 2020

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-crc
/override ci/prow/e2e-libvirt
/override ci/prow/e2e-aws-workers-rhel7
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-openstack
/override ci/prow/e2e-ovirt

@openshift-ci-robot
Copy link
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws, ci/prow/e2e-aws-fips, ci/prow/e2e-aws-upgrade, ci/prow/e2e-aws-workers-rhel7, ci/prow/e2e-crc, ci/prow/e2e-libvirt, ci/prow/e2e-metal-ipi, ci/prow/e2e-openstack, ci/prow/e2e-ovirt

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-crc
/override ci/prow/e2e-libvirt
/override ci/prow/e2e-aws-workers-rhel7
/override ci/prow/e2e-metal-ipi
/override ci/prow/e2e-openstack
/override ci/prow/e2e-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson merged commit de62b01 into openshift:master Oct 23, 2020
@sdodson
Copy link
Member

sdodson commented Oct 23, 2020

/cherrypick release-4.6
/cherrypick release-4.5
/cherrypick release-4.4
/cherrypick release-4.3

@openshift-cherrypick-robot

@sdodson: new pull request created: #4298

In response to this:

/cherrypick release-4.6
/cherrypick release-4.5
/cherrypick release-4.4
/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Oct 23, 2020

/cherrypick release-4.5

@abhinavdahiya abhinavdahiya deleted the add-matthew-owners branch October 23, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants