Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: block cluster destroy in c2s region #4316

Merged
merged 1 commit into from Oct 29, 2020

Conversation

staebler
Copy link
Contributor

The C2S partition does not have resourcetaggingapi. Consequently, the aws destroyer is not able to find resources to clean up when the cluster is installed in that partition. Rather than making the user wait through numerous timeouts and backoffs, fail the destroy command early when the region used for the cluster is the C2S region.

https://issues.redhat.com/browse/CORS-1581

The C2S partition does not have resourcetaggingapi. Consequently,
the aws destroyer is not able to find resources to clean up when
the cluster is installed in that partition. Rather than making the
user wait through numerous timeouts and backoffs, fail the destroy
command early when the region used for the cluster is the C2S region.

https://issues.redhat.com/browse/CORS-1581
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
@staebler
Copy link
Contributor Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@staebler: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt aeeec06 link /test e2e-libvirt
ci/prow/e2e-ovirt aeeec06 link /test e2e-ovirt
ci/prow/e2e-crc aeeec06 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b0c6ae5 into openshift:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants