Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asset/installconfig/gcp: Validate install-config instance types #4329

Merged
merged 2 commits into from Nov 11, 2020
Merged

asset/installconfig/gcp: Validate install-config instance types #4329

merged 2 commits into from Nov 11, 2020

Conversation

jstuever
Copy link
Contributor

Ensure the user provided instance types meets minimum resource
requirements.

patrickdillon
patrickdillon reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

/approve

I left some minor nits. I am happy to /lgtm but want to give a moment in case any one else wants to take a look.

pkg/asset/installconfig/gcp/client.go Outdated Show resolved Hide resolved
pkg/asset/installconfig/gcp/validation.go Outdated Show resolved Hide resolved
pkg/asset/installconfig/gcp/validation.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@patrickdillon
Copy link
Contributor

Needs mocks generated: https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#generating-test-mocks

staebler
staebler reviewed Oct 30, 2020
View reviewed changes
pkg/asset/installconfig/gcp/validation.go Outdated Show resolved Hide resolved
pkg/asset/installconfig/gcp/validation.go Outdated Show resolved Hide resolved
pkg/asset/installconfig/gcp/validation.go Outdated Show resolved Hide resolved
pkg/asset/installconfig/gcp/validation_test.go Outdated Show resolved Hide resolved
@jstuever jstuever changed the title asset/installconfig/gcp: Validate install-config instance types WIP: asset/installconfig/gcp: Validate install-config instance types Nov 2, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2020
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@jstuever
asset/installconfig/gcp: Validate install-config instance types
0d74861 
Ensure the user provided instance types meets minimum resource
requirements.
@jstuever jstuever changed the title WIP: asset/installconfig/gcp: Validate install-config instance types asset/installconfig/gcp: Validate install-config instance types Nov 10, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2020
staebler
staebler approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@staebler
Copy link
Contributor

/test e2e-gcp

Holding to make sure that gcp tests pass.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2020
@mtnbikenc
Copy link
Member

e2e-gcp test passed
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 11, 2020 •
edited

@jstuever: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 0d74861 link /test e2e-ovirt
ci/prow/e2e-crc 0d74861 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1325f20 into openshift:master Nov 11, 2020
@jstuever jstuever deleted the cors1548 branch November 11, 2020 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdando bogdando bogdando left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@staebler staebler staebler approved these changes

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@staebler staebler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jstuever @patrickdillon @openshift-ci-robot @staebler @mtnbikenc @openshift-bot @openshift-merge-robot @bogdando @abhinavdahiya