New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: support custom trust bundle for c2s regions #4335
aws: support custom trust bundle for c2s regions #4335
Conversation
b059c65
to
0f2009f
Compare
0f2009f
to
8c957c8
Compare
When installing to an AWS C2S region, the user needs to be able to specify additional trust bundles to be used when using the AWS API. These trust bundles need to be made available to the operators in the cluster that use the AWS API. With these changes, the additional trust bundle specified in the install config will be included in the "ca-bundle.pem" key of the cloud-provider-config ConfigMap for AWS C2S installs. Also, the additional trust bundle will be made available to the machine-config-operator running on the bootstrap node in the /opt/openshift/tls/cloud-ca-cert.pem file. https://issues.redhat.com/browse/CORS-1584
8c957c8
to
bcb34f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtnbikenc, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@staebler: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
When installing to an AWS C2S region, the user needs to be able to specify additional trust bundles to be used when using the AWS API. These trust bundles need to be made available to the operators in the cluster that use the AWS API.
With these changes, the additional trust bundle specified in the install config will be included in the "ca-bundle.pem" key of the cloud-provider-config ConfigMap for AWS C2S installs.
Also, the additional trust bundle will be made available to the machine-config-operator running on the bootstrap node in the /opt/openshift/tls/cloud-ca-cert.pem file.
https://issues.redhat.com/browse/CORS-1584