Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owners: Add mdbooth to openstack-approvers #4348

Merged
merged 1 commit into from Nov 5, 2020
Merged

owners: Add mdbooth to openstack-approvers #4348

merged 1 commit into from Nov 5, 2020
+2 −0

Conversation

pierreprinetti
Copy link
Member

Add a new team member.

@pierreprinetti
Copy link
Member Author

/cc @mdbooth @mandre

mandre
mandre approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@openshift-merge-robot
Copy link
Contributor

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 2e4bf42 link /test e2e-crc
ci/prow/e2e-ovirt 2e4bf42 link /test e2e-ovirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Fedosin
Fedosin approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@staebler
Copy link
Contributor

staebler commented Nov 5, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, mandre, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit ba47eca into openshift:master Nov 5, 2020
@pierreprinetti pierreprinetti deleted the owners_mdbooth branch November 8, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

@Fedosin Fedosin Fedosin approved these changes

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mandre mandre

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pierreprinetti @openshift-merge-robot @staebler @openshift-ci-robot @mandre @Fedosin