Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/openstack/UPI: improvements #4355

Merged
merged 1 commit into from Nov 9, 2020
Merged

doc/openstack/UPI: improvements #4355

merged 1 commit into from Nov 9, 2020

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Nov 6, 2020 •
edited

  • Update package names for Fedora, now python3
  • Replace the usage of swiftclient by openstackclient
    for container/object creates (which uses clouds.yaml)
  • Fix logs alignment

@EmilienM
doc/openstack/UPI: improvements
9392807 
- Update package names for Fedora, now python3
- Replace the usage of swiftclient by openstackclient
  for container/object creates (which uses clouds.yaml)
- Fix logs alignment
@openshift-merge-robot
Copy link
Contributor

@EmilienM: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 9392807 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member Author

EmilienM commented Nov 6, 2020

/label platform/openstack

mandre
mandre approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 519f21b into openshift:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

@iamemilio iamemilio Awaiting requested review from iamemilio

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EmilienM @openshift-merge-robot @openshift-ci-robot @openshift-bot @mandre