Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt: Bump bootstrap size (primarily for OKD) #4364

Merged
merged 1 commit into from Nov 12, 2020
Merged

libvirt: Bump bootstrap size (primarily for OKD) #4364

merged 1 commit into from Nov 12, 2020

Conversation

cgwalters
Copy link
Member

The FCOS/RHCOS difference of 8GB vs 16GB is something
I'd eventually like to fix by making RHCOS 8GB too for
consistency.

The installer can easily resize.

@cgwalters
Copy link
Member Author

(OK this time actually tested locally)

@stbenjam
Copy link
Member

stbenjam commented Nov 11, 2020 •
edited

Would you mind making the same change to baremetal's bootstrap volume? @hroyrh testing baremetal IPI on OKD has run into the same problem with 8GB disk being too small.

installer/data/data/baremetal/bootstrap/main.tf

Lines 7 to 12 in 8b21f01

resource "libvirt_volume" "bootstrap" {
name = "${var.cluster_id}-bootstrap"
pool = libvirt_pool.bootstrap.name
source = var.image
}

staebler
staebler reviewed Nov 11, 2020
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@cgwalters
Copy link
Member Author

Would you mind making the same change to baremetal's bootstrap volume?

OK took a stab at that, though I don't have the test setup for it handy.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters cgwalters mentioned this pull request Nov 11, 2020
Closed
@cgwalters
Copy link
Member Author

Ah, looks like the baremetal side needed two separate volumes. Took a crack at that.

@cgwalters
libvirt: Bump bootstrap size (primarily for OKD)
2d6bb07 
People have been hitting space issues with OKD (FCOS)
which is 8GB by default.  Eventually I think we
should support something like simulated OpenStack instance
sizes for libvirt.

The FCOS/RHCOS difference of 8GB vs 16GB is something
I'd eventually like to fix by making RHCOS 8GB too for
consistency.
@stbenjam
Copy link
Member

Thank you for applying the baremetal fix.

This LGTM.

/lgtm

@stbenjam
Copy link
Member

stbenjam commented Nov 11, 2020 •
edited

/hold

Feel free to remove when ready. Libvirt failures seem unrelated but I'm not an expert on that platform.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@cgwalters
Copy link
Member Author

I think that's a known SDN flake, see https://bugzilla.redhat.com/show_bug.cgi?id=1886922
In any case this change to the bootstrap size really can't affect the runtime tests of the cluster.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@cgwalters: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 2d6bb07 link /test e2e-ovirt
ci/prow/e2e-crc 2d6bb07 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1557ea4 into openshift:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staebler staebler staebler left review comments

@cfergeau cfergeau Awaiting requested review from cfergeau

@praveenkumar praveenkumar Awaiting requested review from praveenkumar

Assignees

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cgwalters @stbenjam @openshift-ci-robot @openshift-bot @openshift-merge-robot @staebler