Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: make conversion functions private #4376

Merged
merged 1 commit into from Nov 17, 2020
Merged

Cleanup: make conversion functions private #4376

merged 1 commit into from Nov 17, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Nov 13, 2020

Now some functions in "conversion" module are public but they are used only inside the module, so it is reasonable to make them
private.

Also this commit fixes typos in deprecated properties descriptions.

@Fedosin
Cleanup: make conversion functions private
ae4f082 
Now some functions in "conversion" module are public but they are
used only inside the module, so it is reasonable to make them
private.

Also this commit fixes typos in deprecated properties descriptions.
@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 13, 2020

For the context: #4244 (comment)

@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 13, 2020

/assign @wking

staebler
staebler approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 14, 2020

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 15, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 15, 2020

/test e2e-aws

2 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 15, 2020

/test e2e-aws

@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 16, 2020

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 17, 2020 •
edited

@Fedosin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc ae4f082 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fedosin
Copy link
Contributor Author

Fedosin commented Nov 17, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit f697c53 into openshift:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staebler staebler staebler approved these changes

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@wking wking

@staebler staebler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Fedosin @openshift-ci-robot @openshift-bot @openshift-merge-robot @staebler @wking