Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack UPI: Use ansible-galaxy #4379

Merged
merged 1 commit into from Nov 18, 2020

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Nov 13, 2020

Document the use of ansible-galaxy as a dependency manager for the
Ansible playbooks in UPI.

Implements OSASINFRA-2169

Document the use of ansible-galaxy as a dependency manager for the
Ansible playbooks in UPI.

Implements OSASINFRA-2169
@pierreprinetti
Copy link
Member Author

/label platform/openstack

@pierreprinetti
Copy link
Member Author

/test e2e-openstack-upi

@pierreprinetti
Copy link
Member Author

/retest

@pierreprinetti
Copy link
Member Author

/retest

@EmilienM
Copy link
Member

Looking at the CI logs for e2e-openstack-upi, the Ansible portion worked fine: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/4379/pull-ci-openshift-installer-master-e2e-openstack-upi/1327395066704039936

It failed later with a timeout during OCP install, but I don't think this is related to this patch.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-upi 0388cea link /test e2e-openstack-upi
ci/prow/e2e-openstack 0388cea link /test e2e-openstack
ci/prow/e2e-ovirt 0388cea link /test e2e-ovirt
ci/prow/e2e-crc 0388cea link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 657fbc6 into openshift:master Nov 18, 2020
@pierreprinetti pierreprinetti deleted the osasinfra-2169 branch November 18, 2020 10:11
@pierreprinetti
Copy link
Member Author

CC @maxwelldb

@maxwelldb
Copy link
Contributor

maxwelldb commented Nov 23, 2020

@pierreprinetti What's the target release for this? 4.7+? I don't see it in OSASINFRA-2169.

@pierreprinetti
Copy link
Member Author

@maxwelldb That would be 4.7, but I'm trying to understand whether I need to revert this change actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants