New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baremetal: correct the cacheImageURL when we don't have a provisioningIP #4408
baremetal: correct the cacheImageURL when we don't have a provisioningIP #4408
Conversation
Look legit (note this will only be useful once a future change has merged to cluster-baremetal-operator). |
/label platform/baremetal |
Looks good - should hold this until the CBO change is merged? Also perhaps we should add a comment or link to explain why cacheImagePort is different? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This code isn't really reachable without tricks until we remove the validation on ClusterProvisioningIP. It can be tested manually if you're editing the provisioning CR before running create cluster, so there's some value in getting it in now. Let's test disabled networking though: /test e2e-metal-ipi-virtualmedia |
@stbenjam: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift/release#13852 adds virtualmedia to this repo |
/test e2e-metal-ipi-virtualmedia |
2 similar comments
/test e2e-metal-ipi-virtualmedia |
/test e2e-metal-ipi-virtualmedia |
/retest |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@asalkeld: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc @zaneb