Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default release image to 4.7 #4409

Merged

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Nov 24, 2020

Align the default release image with the current development version.

@pierreprinetti
Copy link
Member Author

/uncc jhixson74 patrickdillon

@pierreprinetti pierreprinetti changed the title Set default release image to 4.7 Set default release image to 4.6 Nov 24, 2020
@pierreprinetti
Copy link
Member Author

/cc LorbusChris jhixson74 patrickdillon

@LorbusChris
Copy link
Member

I wonder whether we should go to 4.7 in master directly, and switch to 4.6 only on release-4.6

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Nov 25, 2020

I wonder whether we should go to 4.7 in master directly, and switch to 4.6 only on release-4.6

That was my original idea TBH, however

$ podman pull registry.svc.ci.openshift.org/origin/release:4.7
Trying to pull registry.svc.ci.openshift.org/origin/release:4.7...
  manifest unknown: manifest unknown
Error: unable to pull registry.svc.ci.openshift.org/origin/release:4.7: Error initializing source docker://registry.svc.ci.openshift.org/origin/release:4.7: Error reading manifest 4.7 in registry.svc.ci.openshift.org/origin/release: manifest unknown: manifest unknown

Same with latest, master and nightly. Any ideas?

@pierreprinetti
Copy link
Member Author

/retest

@staebler
Copy link
Contributor

staebler commented Dec 1, 2020

podman pull registry.svc.ci.openshift.org/origin/release:4.7

I wonder whether we should go to 4.7 in master directly, and switch to 4.6 only on release-4.6

That was my original idea TBH, however

$ podman pull registry.svc.ci.openshift.org/origin/release:4.7
Trying to pull registry.svc.ci.openshift.org/origin/release:4.7...
  manifest unknown: manifest unknown
Error: unable to pull registry.svc.ci.openshift.org/origin/release:4.7: Error initializing source docker://registry.svc.ci.openshift.org/origin/release:4.7: Error reading manifest 4.7 in registry.svc.ci.openshift.org/origin/release: manifest unknown: manifest unknown

Same with latest, master and nightly. Any ideas?

The 4.7 image exists. We should definitely move to 4.7.

$ oc image info registry.svc.ci.openshift.org/origin/release:4.7 | head -n4
Name:        registry.svc.ci.openshift.org/origin/release:4.7
Digest:      sha256:bccbfcc0d7c0ce7f1bb5ef5a3dd681cb39501a7c01822d7461440c45554531f8
Media Type:  application/vnd.docker.distribution.manifest.v2+json
Created:     14h ago

Align the default release image with the current development version.
@pierreprinetti pierreprinetti changed the title Set default release image to 4.6 Set default release image to 4.7 Dec 1, 2020
@pierreprinetti
Copy link
Member Author

Created: 14h ago

:) updated

PTAL @staebler

@LorbusChris
Copy link
Member

/approve

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc d438949 link /test e2e-crc
ci/prow/e2e-aws-workers-rhel7 d438949 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4d10fe6 into openshift:master Dec 2, 2020
@pierreprinetti pierreprinetti deleted the update-release-image branch December 2, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants