asset/installconfig/Azure: Validate install-config instance types #4419
Conversation
|
/test e2e-azure |
|
/retest |
|
|
||
| for _, capability := range *typeMeta.Capabilities { | ||
|
|
||
| if strings.EqualFold(*capability.Name, "vCPUs") { |
There was a problem hiding this comment.
Are we willing to accept a SKU that does not have the "vCPUs" or "MemoryGB" capability?
There was a problem hiding this comment.
Currently, if the capability is not present, then we won't show any error. We filter out any SKU that is not of type "virtualMachines". I am unable to find anything in the docs where this type of SKU is guaranteed to have these capabilities specified (or not).
There was a problem hiding this comment.
I think we should move forward as-is. We can always make changes if we find cu issues later on.
Ensure the user provided instance types meets minimum resource requirements.
|
/test e2e-azure |
|
overall looks good. Is this in any is aligned with machine-api to do the same when creating new sets? we seen that in most cases user workaround this by creating a cluster and changing compute types post creation :/ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jstuever: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Ensure the user provided instance types meets minimum resource
requirements.