Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.6] Bug 1901736: openstack: CP nodes port to use addtional SGs #4420

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions data/data/openstack/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ module "topology" {
octavia_support = var.openstack_octavia_support
machines_subnet_id = var.openstack_machines_subnet_id
machines_network_id = var.openstack_machines_network_id
master_extra_sg_ids = var.openstack_master_extra_sg_ids
}

data "openstack_images_image_v2" "base_image" {
Expand Down
11 changes: 7 additions & 4 deletions data/data/openstack/topology/private-network.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,13 @@ resource "openstack_networking_port_v2" "masters" {
name = "${var.cluster_id}-master-port-${count.index}"
count = var.masters_count

admin_state_up = "true"
network_id = local.nodes_network_id
security_group_ids = [openstack_networking_secgroup_v2.master.id]
tags = ["openshiftClusterID=${var.cluster_id}"]
admin_state_up = "true"
network_id = local.nodes_network_id
security_group_ids = concat(
var.master_extra_sg_ids,
[openstack_networking_secgroup_v2.master.id],
)
tags = ["openshiftClusterID=${var.cluster_id}"]

extra_dhcp_option {
name = "domain-search"
Expand Down
5 changes: 5 additions & 0 deletions data/data/openstack/topology/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,8 @@ variable "machines_network_id" {
type = string
default = ""
}

variable "master_extra_sg_ids" {
description = "(optional) IDs of additional security groups for masters."
type = list(string)
}