Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Test manifest creation #4431

Merged
merged 1 commit into from Dec 6, 2020
Merged

openstack: Test manifest creation #4431

merged 1 commit into from Dec 6, 2020

Conversation

pierreprinetti
Copy link
Member

Add a script for testing OpenStack manifest generation.

Co-Authored-By: Matthew Booth mbooth@redhat.com

@pierreprinetti
Copy link
Member Author

/label platform/openstack
/cc mdbooth mandre

@pierreprinetti pierreprinetti force-pushed the test_openstack_manifests branch 2 times, most recently from ea03f0a to 3f25b03 Compare November 30, 2020 17:08
@pierreprinetti pierreprinetti mentioned this pull request Nov 30, 2020
Merged
@iamemilio
Copy link

Glad you guys picked this up! This can help us catch some usage errors that might slip through the cracks of our unit tests, and I'm excited to start playing with this.

/assign

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Nov 30, 2020 •
edited

Glad you guys picked this up! This can help us catch some usage errors that might slip through the cracks of our unit tests, and I'm excited to start playing with this.

/assign

👍

Please play with it! 🙂 The script should print useful error messages when used incorrectly.

Let me know if there is something to fix; this PR is a prerequisite for running the corresponding job in the CI.

@mandre
Copy link
Member

mandre commented Dec 1, 2020

I like the idea of validating the generated manifests, this allows to increase the test coverage and prevent a whole class of regressions at low expenses in terms of CI resources.

staebler
staebler reviewed Dec 1, 2020
View reviewed changes
hack/test-manifests-openstack.sh Outdated
@@ -0,0 +1,118 @@
#!/usr/bin/env bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to put this file at hack/openstack/test-manifests.sh so that the OpenStack team can own it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great suggestion. Done!

@pierreprinetti @mdbooth
openstack: Test manifest creation
b852762 
Add a script for testing OpenStack manifest generation.

Co-Authored-By: Matthew Booth <mbooth@redhat.com>
mandre
mandre reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@pierreprinetti
Copy link
Member Author

@staebler PTAL :)

staebler
staebler reviewed Dec 4, 2020
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Dec 5, 2020 •
edited

/skip

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member Author

/test e2e-aws

@pierreprinetti
Copy link
Member Author

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 5, 2020 •
edited

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt b852762 link /test e2e-ovirt
ci/prow/e2e-crc b852762 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit ea6e89a into openshift:master Dec 6, 2020
@pierreprinetti pierreprinetti deleted the test_openstack_manifests branch December 6, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@staebler staebler staebler left review comments

@Fedosin Fedosin Awaiting requested review from Fedosin

@jstuever jstuever Awaiting requested review from jstuever

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mandre mandre

@iamemilio iamemilio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pierreprinetti @iamemilio @mandre @openshift-ci-robot @openshift-bot @openshift-merge-robot @staebler