Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openstack: describes how to enable qemu agent for UPI. #4441

Merged
merged 1 commit into from Dec 10, 2020
Merged

Openstack: describes how to enable qemu agent for UPI. #4441

merged 1 commit into from Dec 10, 2020

Conversation

adduarte
Copy link

@adduarte adduarte commented Dec 2, 2020 •
edited by openshift-ci-robot

implements OSASINFRA-2191

@adduarte
Copy link
Author

adduarte commented Dec 2, 2020

/label platform/openstack

mandre
mandre reviewed Dec 4, 2020
View reviewed changes
docs/user/openstack/install_upi.md Outdated Show resolved Hide resolved
docs/user/openstack/install_upi.md Outdated Show resolved Hide resolved
@adduarte adduarte requested a review from mandre December 10, 2020 07:04
@openshift-merge-robot
Copy link
Contributor

@adduarte: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 3e65c35 link /test e2e-metal-ipi
ci/prow/e2e-aws-workers-rhel7 3e65c35 link /test e2e-aws-workers-rhel7
ci/prow/e2e-metal-ipi-ovn-ipv6 768568a link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc 768568a link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mandre
mandre reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little typo, looks good otherwise.

docs/user/openstack/install_upi.md Outdated
If the RHCOS image being used supports it, the [KVM Qemu Guest Agent][qemu_guest_agent] may be used to enable optional
access between OpenStack KVM hypervisors and the cluster nodes.

To enable this feature, you must add the `hw_qemu_guest_agent=yes` poperty to the image:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To enable this feature, you must add the `hw_qemu_guest_agent=yes` poperty to the image:
To enable this feature, you must add the `hw_qemu_guest_agent=yes` property to the image:

mandre
mandre reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6cbe488 into openshift:master Dec 10, 2020
@pierreprinetti pierreprinetti deleted the enable_qemu_agent_for_upi branch December 10, 2020 13:22
@iamemilio
Copy link

iamemilio commented Dec 15, 2020 •
edited by openshift-ci-robot

Implements: OSASINFRA-2192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@EmilienM EmilienM Awaiting requested review from EmilienM

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adduarte @openshift-merge-robot @openshift-ci-robot @iamemilio @mandre