openstack: Allow to skip pre-flight validations #4452
Conversation
|
/cc mandre mdbooth |
pierreprinetti
force-pushed
the
OSASINFRA-2194
branch
from
609ee79
to
e64f74a
Compare
|
/lgtm |
|
/cc @staebler Sorry to ping you for a platform-specific change, but this flag I'm introducing is potentially controversial and I want to be sure I'm not doing something wrong. Here I introduce an undocumented, dev-only environment variable for disabling pre-flight validations. My use-case: I want to test manifest generation for Nova availability zones, and I don't want to need a cloud with actual AZs for testing the manifests. Is this change acceptable? |
openshift-ci-robot
added
the
do-not-merge/hold
|
This sounds similar to something we had to solve for baremetal IPI. We only do data validations (formatting, presence, etc) in the Platform validator, and moving the rest to the Provisioning validators which only happen at |
Thank you! I'm hoping that I can merge this dev flag before FF, but yours sounds like a good proper solution for when master is open again. |
openshift-ci-robot
removed
the
do-not-merge/hold
There was a problem hiding this comment.
I'm curious what the discussions were initially around doing these validations every time that the install config is generated or loaded rather than waiting until it is time to actually create the cluster. I've always found it a bit strange that I could not create manifests without having a real server to talk to. While I would like to generally discourage the use of environment variables to direct behavior, I can live with this as a short-term solution until we can come up with a better solution--ideally usable by all platforms.
/hold cancel
Skip pre-flight validations when the development-only variable `OPENSHFIT_INSTALL_SKIP_PREFLIGHT_VALIDATIONS=1` is found in the environment. Skipping pre-flight validations is essential to testing manifest generation when the exotic settings under test are not available in the CI infrastructure. Implements OSASINFRA-2194
pierreprinetti
force-pushed
the
OSASINFRA-2194
branch
from
e64f74a
to
39478ff
Compare
agree. we'll revisit that. Thank you. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@pierreprinetti: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam @staebler |
Skip pre-flight validations when the development-only variable
OS_SKIP_PREFLIGHT_VALIDATIONS=1is found in the environment.Skipping pre-flight validations is essential to testing manifest
generation when the exotic settings under test are not available in the
CI infrastructure.
Implements OSASINFRA-2194
/label platform/openstack