Bug 1908171: fix Terraform issue with GCP custom machine types #4496
Conversation
Similar to previous bug (see below) but in this case for custom machine types. In the previous bz, the config generated by Terraform did not match the resource that was ultimately created. So when apply is run a second time for bootstrap destroy, an error occurs when TF tries to switch the resource back to match the config. Similar: fdefcca
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@patrickdillon: This pull request references Bugzilla bug 1908171, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-medium
|
@patrickdillon: This pull request references Bugzilla bug 1908171, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/retest |
openshift-ci-robot
added
lgtm
|
/test e2e-gcp |
|
/hold for e2e-gcp |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold e2e-gcp passed. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@patrickdillon: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@patrickdillon: All pull requests linked via external trackers have merged: Bugzilla bug 1908171 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Similar to previous bug (see below) but in this case for custom machine types. In the previous bz, the config generated by Terraform did not match the resource that was ultimately created. So when apply is run a second time for bootstrap destroy, an error occurs when TF tries to switch the resource back to match the config.
Similar: fdefcca
The error message states:
We could potentially add
service_accountandenable display(however that is handled in TF) to prevent this error from happening in those cases, but I chose to opt for the minimal change and wait and see if those become a problem.