Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1899161: backports for storage flavor checks #4499

Closed
wants to merge 4 commits into from
Closed

Bug 1899161: backports for storage flavor checks #4499

wants to merge 4 commits into from

Conversation

EmilienM
Copy link
Member

This is a combination of 4 backports in order to properly
cherry-pick #4323 without conflict:

  • openstack: Skip validation for baremetal flavors
  • openstack: Fix error messages in flavor validation
  • Patch Flavor Not Found validation for OpenStack Install Config
  • openstack: consider volumes for storage requirements checks

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1899161

pierreprinetti and others added 4 commits December 21, 2020 14:27
@pierreprinetti @EmilienM
openstack: Skip validation for baremetal flavors
ea71dc7 
Baremetal flavor metadata in Glance often contains placeholder
information. With this change, pre-flight validation is no longer
performed for flavors itentified as baremetal.

(cherry picked from commit 6e5ef40)
@pierreprinetti @EmilienM
openstack: Fix error messages in flavor validation
58c4013 
Flavor validation was reporting issues with wrong `install-config.yaml`
property names.

(cherry picked from commit 352c058)
@EmilienM
Patch Flavor Not Found validation for OpenStack Install Config
c83e75e 
Flavors are always added to the Flavors map, however if they are not found
the flavor pointer is nil. Corrected the code logic to account for this.

(cherry picked from commit 4330bb0)
@EmilienM
openstack: consider volumes for storage requirements checks
7f35869 
It is possible to boot a server without using ephemeral storage, with
boot from volume:
https://docs.openstack.org/cinder/latest/admin/blockstorage-boot-from-volume.html

This patch will disable flavor storage check if rootVolume is used in
the Machine Pool and checks that the volume is at least 25Gb sized.

https://bugzilla.redhat.com/show_bug.cgi?id=1891543

Signed-off-by: Emilien Macchi <emilien@redhat.com>
(cherry picked from commit 1b400b4)
@openshift-ci-robot
Copy link
Contributor

@EmilienM: This pull request references Bugzilla bug 1899161, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1899161: backports for storage flavor checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 21, 2020
@openshift-ci-robot
Copy link
Contributor

@EmilienM: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign emilienm after the PR has been reviewed.
You can assign the PR to them by writing /assign @emilienm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Member Author

wrong branch, sorry for noise

@EmilienM EmilienM closed this Dec 21, 2020
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2020

@EmilienM: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/tf-lint 7f35869 link /test tf-lint
ci/prow/tf-fmt 7f35869 link /test tf-fmt
ci/prow/yaml-lint 7f35869 link /test yaml-lint
ci/prow/verify-codegen 7f35869 link /test verify-codegen
ci/prow/verify-vendor 7f35869 link /test verify-vendor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM EmilienM deleted the bz/1899161 branch December 21, 2020 19:41
@EmilienM EmilienM restored the bz/1899161 branch December 21, 2020 19:42
@EmilienM EmilienM deleted the bz/1899161 branch December 21, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre Awaiting requested review from mandre

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees
No one assigned
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EmilienM @openshift-ci-robot @pierreprinetti