Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1894678: Patch Flavor Not Found validation for OpenStack Install Config #4505

Merged
merged 1 commit into from Dec 22, 2020
Merged

Bug 1894678: Patch Flavor Not Found validation for OpenStack Install Config #4505

merged 1 commit into from Dec 22, 2020

Conversation

pierreprinetti
Copy link
Member

Flavors are always added to the Flavors map, however if they are not found
the flavor pointer is nil. Corrected the code logic to account for this.

Bug 1894678
Backports #4289

@pierreprinetti
Patch Flavor Not Found validation for OpenStack Install Config
3b2953c 
Flavors are always added to the Flavors map, however if they are not found
the flavor pointer is nil. Corrected the code logic to account for this.

Bug 1894678
Backports openshift#4289
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1894678, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1887863 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1887863 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

Bug 1894678: Patch Flavor Not Found validation for OpenStack Install Config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 22, 2020
@pierreprinetti pierreprinetti mentioned this pull request Dec 22, 2020
Closed
@pierreprinetti
Copy link
Member Author

/label platform/openstack
/cc mandre EmilienM

@pierreprinetti
Copy link
Member Author

This is a rebase of #4344 on top of the current release-4.6 branch.
/cc iamemilio

@EmilienM
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@pierreprinetti
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@pierreprinetti
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: This pull request references Bugzilla bug 1894678, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1887863 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1887863 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Dec 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@markmc
Copy link
Contributor

markmc commented Dec 22, 2020

(patch manager) it seems this is related to #4383 and resolving an issue with flavor validation that is impacting a number of real-world users

@markmc markmc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 22, 2020
@EmilienM
Copy link
Member

(patch manager) it seems this is related to #4383 and resolving an issue with flavor validation that is impacting a number of real-world users

thanks Mark, FYI this is related to https://bugzilla.redhat.com/show_bug.cgi?id=1899161 and we'll have another backport (last one) after this PR is merged.

@openshift-merge-robot openshift-merge-robot merged commit 899273a into openshift:release-4.6 Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1894678 has been moved to the MODIFIED state.

In response to this:

Bug 1894678: Patch Flavor Not Found validation for OpenStack Install Config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the openstack-flavor-validations-4.6 branch December 22, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@mandre mandre Awaiting requested review from mandre

@EmilienM EmilienM Awaiting requested review from EmilienM

@iamemilio iamemilio Awaiting requested review from iamemilio

Assignees

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pierreprinetti @openshift-ci-robot @EmilienM @openshift-bot @markmc @openshift-merge-robot