New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1910070: Set termination_grace_period_seconds to 10 minutes #4511
Bug 1910070: Set termination_grace_period_seconds to 10 minutes #4511
Conversation
@nirarg: This pull request references Bugzilla bug 1910070, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
82686dd
to
17ef268
Compare
/lgtm |
/retest |
Please improve your commit messages. See https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format. |
Upgrade terraform-provider-kubevirt to a version which allows modifying termination_grace_period_seconds parameter in VM creation
VM termination grace period is changed to 10 minutes in order to prevent situation in which the VM is killed during the shutdown process, which might cause to XFS metadata corruption that can be recovered only manually
17ef268
to
df29088
Compare
/retest |
/lgtm |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenyosef, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@nirarg: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@nirarg: All pull requests linked via external trackers have merged: Bugzilla bug 1910070 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.