New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1908583: Set same additional networks on Bootstrap as Control Plane #4528
Bug 1908583: Set same additional networks on Bootstrap as Control Plane #4528
Conversation
/retest |
1 similar comment
/retest |
@iamemilio: This pull request references Bugzilla bug 1908583, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The bootstrap node was only being attached to the private network created by the installer, causing deployments with more advanced networking topologies that made use of the additional networking feature to fail. The bootstrap needs to be attached to the same networks as the control plane nodes in order to guarantee the install will succeed. Fixes Bug 1908583
f5d374f
to
57d4e4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@iamemilio: All pull requests linked via external trackers have merged: Bugzilla bug 1908583 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.6 |
@iamemilio: new pull request created: #4535 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I would have loved to see this change reflected in the user documentation. And at this point, we should also probably have the boostrap node follow the |
The bootstrap node was only being attached to the private network created by the installer,
causing deployments with more advanced networking topologies that made use of the additional
networking feature to fail. The bootstrap needs to be attached to the same networks as the
control plane nodes in order to guarantee the install will succeed.
Fixes Bug 1908583
/label platform/openstack