Bug 1908468: azure/validation: some memory values are float and not int #4530
Conversation
jstuever
changed the title
|
@jstuever: This pull request references Bugzilla bug 1908468, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
/test e2e-azure |
| if err != nil { | ||
| return append(allErrs, field.InternalError(fieldPath, err)) | ||
| } | ||
| if cpus < req.minimumVCpus { | ||
| if cpus < float64(req.minimumVCpus) { |
There was a problem hiding this comment.
Should we change minimumVCpus and minimumMemory to a float rather than casting at comparison time?
There was a problem hiding this comment.
I debated the same. My concerns were 1) trying to keep the code as similar as possible between the different platforms, and 2) that the output[1] for invalid CPU/Memory would be different showing an int in some platforms and a float in others. I'm happy to use defined floats instead if you think that is more appropriate.
[1]
There was a problem hiding this comment.
Sounds good. Let's leave it as integers.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jstuever: All pull requests linked via external trackers have merged: Bugzilla bug 1908468 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change fixes an issue where the memory values for azure instances were assumed to be integer while some of them were actually floating point values.