Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1915460: ovirt: validate cluster name during install #4537

Merged
merged 1 commit into from Jan 20, 2021
Merged

Bug 1915460: ovirt: validate cluster name during install #4537

merged 1 commit into from Jan 20, 2021

Conversation

dougsland
Copy link
Contributor

Similar to OpenStack platform, we require to
validate cluster name size to avoid DNS resolution
issues in the deploy.

See also: https://github.com/openshift/installer/pull/2270/commits

Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com

@openshift-ci-robot
Copy link
Contributor

@dougsland: This pull request references Bugzilla bug 1915460, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1915460: ovirt: validate cluster name during install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 12, 2021
@dougsland
Copy link
Contributor Author

/assign @Gal-Zaidman

@dougsland
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@dougsland: This pull request references Bugzilla bug 1915460, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougsland
Copy link
Contributor Author

/retest

2 similar comments
@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

doesnt seems related to the patch
/retest

@Gal-Zaidman
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@Gal-Zaidman
Copy link
Contributor

/assign @abhinavdahiya @staebler

@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

/test e2e-aws-fips

2 similar comments
@dougsland
Copy link
Contributor Author

/test e2e-aws-fips

@dougsland
Copy link
Contributor Author

/test e2e-aws-fips

staebler
staebler reviewed Jan 14, 2021
View reviewed changes
pkg/asset/installconfig/ovirt/validation.go Outdated Show resolved Hide resolved
pkg/types/ovirt/validation/platform.go Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
staebler
staebler reviewed Jan 14, 2021
View reviewed changes
pkg/types/ovirt/validation/platform.go Outdated Show resolved Hide resolved
pkg/types/ovirt/validation/platform.go Outdated Show resolved Hide resolved
@dougsland
Copy link
Contributor Author

@staebler totally agreed. Here a new try.

@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

/retest

1 similar comment
@dougsland
Copy link
Contributor Author

/retest

staebler
staebler reviewed Jan 19, 2021
View reviewed changes
pkg/validate/validate.go Outdated Show resolved Hide resolved
pkg/validate/validate.go Outdated Show resolved Hide resolved
pkg/asset/installconfig/clustername.go Outdated Show resolved Hide resolved
pkg/types/validation/installconfig.go Outdated Show resolved Hide resolved
pkg/validate/validate.go Outdated Show resolved Hide resolved
@dougsland
Copy link
Contributor Author

/retest

2 similar comments
@dougsland
Copy link
Contributor Author

/retest

@dougsland
Copy link
Contributor Author

/retest

staebler
staebler reviewed Jan 20, 2021
View reviewed changes
pkg/validate/validate.go Outdated Show resolved Hide resolved
@dougsland
Bug 1915460: ovirt: validate cluster name during install
7b01b29 
Similar to OpenStack platform, we require to
validate cluster name size to avoid DNS resolution
issues in the deploy.

See also: https://github.com/openshift/installer/pull/2270/commits

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
staebler
staebler reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit 27fd27b into openshift:master Jan 20, 2021
@openshift-ci-robot
Copy link
Contributor

@dougsland: All pull requests linked via external trackers have merged:

Bugzilla bug 1915460 has been moved to the MODIFIED state.

In response to this:

Bug 1915460: ovirt: validate cluster name during install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staebler staebler staebler left review comments

@eslutsky eslutsky Awaiting requested review from eslutsky

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@abhinavdahiya abhinavdahiya

@staebler staebler

@Gal-Zaidman Gal-Zaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dougsland @openshift-ci-robot @Gal-Zaidman @staebler @abhinavdahiya @openshift-merge-robot