Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1916373: upi: allow IPsec ports #4552

Merged

Conversation

markdgray
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

@markdgray: This pull request references Bugzilla bug 1916373, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1916373: ipi: allow IPsec ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 14, 2021
@markdgray markdgray changed the title Bug 1916373: ipi: allow IPsec ports Bug 1916373: upi: allow IPsec ports Jan 14, 2021
@markdgray
Copy link
Contributor Author

/retest

@markdgray
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

@markdgray: This pull request references Bugzilla bug 1916373, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray
Copy link
Contributor Author

/retest

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one discrepancy between the IPI and UPI. The rest looks good.

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Hold for passing UPI e2e tests.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2021
@staebler
Copy link
Contributor

/test e2e-aws-upi
/test e2e-gcp-upi
/test e2e-openstack-upi

@markdgray
Copy link
Contributor Author

/retest

@markdgray
Copy link
Contributor Author

The failures look to be unrelated flakes.

/test e2e-aws-upi
/test e2e-gcp-upi
/test e2e-openstack-upi

@markdgray
Copy link
Contributor Author

/test e2e-aws-upi
/test e2e-gcp-upi
/test e2e-openstack-upi

@markdgray
Copy link
Contributor Author

timeouts during install "Get "https://registry.build02.ci.openshift.org/openshift/token?account=user&scope=repository%3Aci-op-r8d57l95%2Fstable%3Apull": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"

/retest

@markdgray
Copy link
Contributor Author

@staebler Do these look like known issues or could it be a bug in the rules? I am not familiar with these build jobs?

@staebler
Copy link
Contributor

@staebler Do these look like known issues or could it be a bug in the rules? I am not familiar with these build jobs?

The e2e-aws-upi test is failing on creating the resources, but from the history of that test it is not evident that it is related to the changes in this PR. I would still like to get at least a successful install, though.
/test e2e-aws-upi

The e2e-gcp-upi test looks like it is broken missing a dependency. This is not related to the changes in this PR. It has been broken since at least July.

CommandException: The signurl command requires the pyopenssl library (try pip install pyopenssl or easy_install pyopenssl)

The e2e-openshift-upi test did have one green pass and is at least installing on other runs. I am satisfied with that.

@staebler
Copy link
Contributor

/test e2e-aws-upi

4 similar comments
@markdgray
Copy link
Contributor Author

/test e2e-aws-upi

@markdgray
Copy link
Contributor Author

/test e2e-aws-upi

@markdgray
Copy link
Contributor Author

/test e2e-aws-upi

@markdgray
Copy link
Contributor Author

/test e2e-aws-upi

@staebler
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2021

@markdgray: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upi 618d4ef link /test e2e-aws-upi
ci/prow/e2e-gcp-upi 618d4ef link /test e2e-gcp-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c7a3e2b into openshift:master Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@markdgray: All pull requests linked via external trackers have merged:

Bugzilla bug 1916373 has been moved to the MODIFIED state.

In response to this:

Bug 1916373: upi: allow IPsec ports

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@markdgray markdgray deleted the fix/ipsec_upi/1916373 branch January 21, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants