New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1912828: Rebase on the latest terraform provider/go-ovirt #4562
Bug 1912828: Rebase on the latest terraform provider/go-ovirt #4562
Conversation
Gal-Zaidman
commented
Jan 18, 2021
- Align High Performance VMs with High Performance in RHV-UI
- Improve disk upload check
- Rebase on latest go-ovirt
- Rebase on latest terraform-provider-ovirt
- Improve disk upload check - Rebase on latest go-ovirt - Rebase on latest terraform-provider-ovirt - Align High Performance VMs with High Performance in RHV-UI
@Gal-Zaidman: This pull request references Bugzilla bug 1916486, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Gal-Zaidman: This pull request references Bugzilla bug 1912828, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@Gal-Zaidman: This pull request references Bugzilla bug 1912828, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @staebler |
/test unit |
/lgtm @Gal-Zaidman 🤷♂️ |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm @Gal-Zaidman |
/lgtm |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold |
On the new go-ovirt SDK the logic for testing a connection was change to making a call to the engine and not just check the certificate, see[1]. This caused the logic of the test to get broken since there is no real ovirt engine to test against. The test itself was a bit pointless anyway since it tested mostly the ovirt engine and not logic of the installer [1] oVirt/ovirt-engine-sdk-go@92c1875
/lgtm |
/unhold |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@Gal-Zaidman: All pull requests linked via external trackers have merged: Bugzilla bug 1912828 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |