New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1916938: tolerate equal APIFloatingIP and LbFloatingIP #4575
Bug 1916938: tolerate equal APIFloatingIP and LbFloatingIP #4575
Conversation
In 4.7 LbFloatingIP was deprecated and renamed to APIFloatingIP. But if we regenerate a config from 4.6 version, it doesn't unset the deprecated LbFloatingIP and both values are present in the new config, which leads to an error. This commit allows to set both parameters in the config, but only if their values are equal. /label platform/openstack
@Fedosin: This pull request references Bugzilla bug 1916938, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@Fedosin: This pull request references Bugzilla bug 1916938, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws |
/test e2e-aws-upgrade |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@Fedosin: All pull requests linked via external trackers have merged: Bugzilla bug 1916938 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In 4.7 LbFloatingIP was deprecated and renamed to APIFloatingIP.
But if we regenerate a config from 4.6 version, it doesn't unset the deprecated LbFloatingIP and both values are present in the new config, which leads to an error.
This commit allows to set both parameters in the config, but only if their values are equal.
/label platform/openstack