Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1916938: tolerate equal APIFloatingIP and LbFloatingIP #4575

Merged
merged 1 commit into from Jan 22, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Jan 21, 2021

In 4.7 LbFloatingIP was deprecated and renamed to APIFloatingIP.
But if we regenerate a config from 4.6 version, it doesn't unset the deprecated LbFloatingIP and both values are present in the new config, which leads to an error.

This commit allows to set both parameters in the config, but only if their values are equal.

/label platform/openstack

In 4.7 LbFloatingIP was deprecated and renamed to APIFloatingIP.
But if we regenerate a config from 4.6 version, it doesn't unset the
deprecated LbFloatingIP and both values are present in the new config,
which leads to an error.

This commit allows to set both parameters in the config, but only if
their values are equal.

/label platform/openstack
@openshift-ci-robot openshift-ci-robot added platform/openstack bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1916938, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1916938: tolerate equal APIFloatingIP and LbFloatingIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 21, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1916938, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 21, 2021
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 21, 2021

/test e2e-aws

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 21, 2021

/test e2e-aws-upgrade

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 21, 2021

/retest

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d19070a into openshift:master Jan 22, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 1916938 has been moved to the MODIFIED state.

In response to this:

Bug 1916938: tolerate equal APIFloatingIP and LbFloatingIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. platform/openstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants