Bug 1940275: Revert "baremetal: send full ignition to masters" #4767

kirankt · 2021-03-18T02:15:14Z

This bug is a manual cherry-pick of #4722 for 4.7 release.

From #4722:

This doesn't work for IPI baremetal deployments driven via hive,
because there are firewall rules that prevent access to the
bootstrap MCS from the pod running the installer.

This was implemented in:
#4427

But we ran into problems making the same approach work for
worker machines ref:
#4456

We're now looking at other approaches to resolve the
network-config requirements driving that work, so
switching back to the pointer config for masters seems
reasonable, particularly given this issue discovered for
hive deployments.

Conflicts:
pkg/tfvars/baremetal/baremetal.go

This reverts commit 98dc381.

openshift-ci-robot · 2021-03-18T02:15:18Z

@kirankt: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kirankt · 2021-03-18T02:17:26Z

/label platform/baremetal

kirankt · 2021-03-18T02:18:24Z

/cc @hardys @stbenjam

hardys · 2021-03-19T12:00:54Z

Thanks for proposing this @kirankt - we need to take care of the merge conflict in pkg/tfvars/baremetal/baremetal.go

kirankt · 2021-03-19T14:05:29Z

Thanks, @hardys . That was weird. I don't see the merge conflict in my local copy. :-(. In any case, I took care of it using the manual merge feature in the GUI.

staebler · 2021-03-21T02:30:17Z

The following tests should not be required.
/override ci/prow/e2e-kubevirt
/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-openstack-ipi

openshift-ci-robot · 2021-03-21T02:30:33Z

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-kubevirt, ci/prow/e2e-metal-assisted, ci/prow/e2e-openstack-ipi

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cdoan1 · 2021-03-31T19:11:11Z

@staebler seem all the tests passed, any outlook on when this can land?

stbenjam · 2021-03-31T19:25:00Z

/approve
/lgtm

However, see above message from the bot, https://bugzilla.redhat.com/show_bug.cgi?id=1936443 needs to get QE'd first. Once that's done, this will get selected for an OpenShift z-stream sometime after that by the patch manager on duty.

openshift-ci-robot · 2021-03-31T19:25:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~data/data/baremetal/OWNERS~~ [stbenjam]
~~pkg/tfvars/baremetal/OWNERS~~ [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-01T01:00:59Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-01T01:01:04Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-02T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-02T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-03T01:01:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-03T01:01:21Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-04T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-04T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-30T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-01T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-05-01T01:00:48Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-02T01:00:44Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-05-02T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-03T01:00:24Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-05-03T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-04T01:00:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-05-04T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-05T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-05-05T01:01:17Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-06T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-05-06T01:01:21Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-07T01:01:12Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-07T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-08T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-08T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-09T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-09T01:01:17Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-10T01:01:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-10T01:01:24Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-11T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-05-11T01:01:00Z

@openshift-bot: This pull request references Bugzilla bug 1940275, which is invalid:

expected dependent Bugzilla bug 1936443 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys · 2021-05-11T14:38:36Z

/bugzilla refresh

openshift-ci · 2021-05-11T14:38:46Z

@hardys: This pull request references Bugzilla bug 1940275, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1936443 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1936443 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-05-14T22:39:20Z

@kirankt: All pull requests linked via external trackers have merged:

openshift/installer#4767

Bugzilla bug 1940275 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Revert baremetal: send full ignition to masters

343d90c

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 18, 2021

openshift-ci-robot requested review from celebdor and russellb March 18, 2021 02:15

openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Mar 18, 2021

openshift-ci-robot requested review from hardys and stbenjam March 18, 2021 02:18

Merge branch 'release-4.7' into 4.7-ignition-revert

9dbbbad

openshift-ci-robot assigned stbenjam Mar 31, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 11, 2021

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 14, 2021

openshift-merge-robot merged commit d585f92 into openshift:release-4.7 May 14, 2021

Bug 1940275: Revert "baremetal: send full ignition to masters" #4767

Bug 1940275: Revert "baremetal: send full ignition to masters" #4767

Conversation

kirankt commented Mar 18, 2021

From #4722:

openshift-ci-robot commented Mar 18, 2021

kirankt commented Mar 18, 2021 • edited

kirankt commented Mar 18, 2021

hardys commented Mar 19, 2021

kirankt commented Mar 19, 2021

staebler commented Mar 21, 2021

openshift-ci-robot commented Mar 21, 2021

cdoan1 commented Mar 31, 2021

stbenjam commented Mar 31, 2021

openshift-ci-robot commented Mar 31, 2021

openshift-bot commented Apr 1, 2021

openshift-ci-robot commented Apr 1, 2021

openshift-bot commented Apr 2, 2021

openshift-ci-robot commented Apr 2, 2021

openshift-bot commented Apr 3, 2021

openshift-ci-robot commented Apr 3, 2021

openshift-bot commented Apr 4, 2021

openshift-ci-robot commented Apr 4, 2021

openshift-ci-robot commented Apr 30, 2021

openshift-bot commented May 1, 2021

openshift-ci-robot commented May 1, 2021

openshift-bot commented May 2, 2021

openshift-ci-robot commented May 2, 2021

openshift-bot commented May 3, 2021

openshift-ci-robot commented May 3, 2021

openshift-bot commented May 4, 2021

openshift-ci-robot commented May 4, 2021

openshift-bot commented May 5, 2021

openshift-ci-robot commented May 5, 2021

openshift-bot commented May 6, 2021

openshift-ci-robot commented May 6, 2021

openshift-bot commented May 7, 2021

openshift-ci bot commented May 7, 2021

openshift-bot commented May 8, 2021

openshift-ci bot commented May 8, 2021

openshift-bot commented May 9, 2021

openshift-ci bot commented May 9, 2021

openshift-bot commented May 10, 2021

openshift-ci bot commented May 10, 2021

openshift-bot commented May 11, 2021

openshift-ci bot commented May 11, 2021

hardys commented May 11, 2021

openshift-ci bot commented May 11, 2021

openshift-ci bot commented May 14, 2021

kirankt commented Mar 18, 2021 •

edited