Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1935174: RHCOS bump for LUKS, prjquota, etc #4791

Conversation

miabbott
Copy link
Member

This bumps the boot image to to include fixes for the following:

BZ#1922417 - Issue configuring nodes with VLAN and teaming
BZ#1940966 - [4.7.z] prjquota is dropped from rootflags if rootfs is reprovisioned
BZ#1941760 - [4.7.z] rootfs too small when enabling NBDE (redo)
BZ#1942706 - [4.7.z] support new AWS region ap-northeast-3

This bumps the boot image to to include fixes for the following:

BZ#1922417 - Issue configuring nodes with VLAN and teaming
BZ#1940966 - [4.7.z] prjquota is dropped from rootflags if rootfs is reprovisioned
BZ#1941760 - [4.7.z] rootfs too small when enabling NBDE (redo)
BZ#1942706 - [4.7.z] support new AWS region ap-northeast-3
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 25, 2021
@openshift-ci-robot
Copy link
Contributor

@miabbott: This pull request references Bugzilla bug 1935174, which is invalid:

  • expected dependent Bugzilla bug 1922417 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1940966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1941760 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1942706 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1922417 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1940966 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1941760 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1942706 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1935174: RHCOS bump for LUKS, prjquota, etc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 25, 2021
@miabbott
Copy link
Member Author

/assign jlebon

@jlebon
Copy link
Member

jlebon commented Mar 25, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@miabbott
Copy link
Member Author

e2e-metal-assisted appears to be perma-failing on https://bugzilla.redhat.com/show_bug.cgi?id=1939560

e2e-kubevirt has been perma-failing for the last 10 days; filed https://bugzilla.redhat.com/show_bug.cgi?id=1943362

e2e-openstack looks like it failed on https://bugzilla.redhat.com/show_bug.cgi?id=1926269

e2e-aws failing on [sig-api-machinery][Feature:APIServer][Late] kubelet terminates kube-apiserver gracefully [Suite:openshift/conformance/parallel] which is linked to https://bugzilla.redhat.com/show_bug.cgi?id=1926484 in VERIFIED state. So I filed a new one https://bugzilla.redhat.com/show_bug.cgi?id=1943364

Will examine other failures later.

/retest

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1935174, which is invalid:

  • expected dependent Bugzilla bug 1922417 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1940966 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1941760 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
  • expected dependent Bugzilla bug 1942706 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1922417 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1940966 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1941760 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1942706 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@staebler
Copy link
Contributor

/approve
/override ci/prow/e2e-kubevirt
/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-openstack-ipi
/override ci/prow/e2e-vsphere-upi

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2021
@openshift-ci-robot
Copy link
Contributor

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-kubevirt, ci/prow/e2e-metal-assisted, ci/prow/e2e-openstack-ipi, ci/prow/e2e-vsphere-upi

In response to this:

/approve
/override ci/prow/e2e-kubevirt
/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-openstack-ipi
/override ci/prow/e2e-vsphere-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Member Author

Regarding the BZ status:

We can probably get 1922417, 1940966, 1941760 verified today or early next week.

1942706 is the support for ap-northeast-3 which is covered by this PR.

All of the referenced BZs are targeting 4.7.z as they are expected to be fixed in that release, so I don't understand why the bot complains about them.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1935174, which is invalid:

  • expected dependent Bugzilla bug 1942706 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1922417 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1940966 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1941760 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1942706 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1935174, which is invalid:

  • expected dependent Bugzilla bug 1942706 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1922417 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1940966 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1941760 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1942706 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1935174, which is invalid:

  • expected dependent Bugzilla bug 1942706 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 1922417 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1940966 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1941760 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1942706 to target a release in 4.8.0, but it targets "4.7.z" instead
  • expected dependent Bugzilla bug 1934863 to target a release in 4.8.0, but it targets "4.7.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member Author

/hold

It looks like the AWS SDK needs to be bumped to support the ap-northeast-3 region

@staebler
Copy link
Contributor

/hold
It looks like the AWS SDK needs to be bumped to support the ap-northeast-3 region

Why does this PR need to be held for the AWS SDK bump?

When building this locally, the ap-northeast-3 region isn't a selectable region when doing openshift-install create cluster

Right. But adding support in the RHCOS image is separate from the installer offering the region as a valid region.

@miabbott
Copy link
Member Author

/hold cancel

@staebler has a different approach to support new AWS regions in #4801

We should be able to land this PR independently of #4801

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@miabbott
Copy link
Member Author

miabbott commented Mar 30, 2021

@staebler could you override the invalid bug flag? The associated BZs are fixed in RHCOS 4.7 (except for the ap-northeast-3 one) and are targeting 4.7.z

(They actually were incorrectly attached to the last 4.7.z errata that went out, so the sooner we can get this change shipped the better)

@staebler
Copy link
Contributor

@staebler could you override the invalid bug flag? The associated BZs are fixed in RHCOS 4.7 (except for the ap-northeast-3 one) and are targeting 4.7.z

(They actually were incorrectly attached to the last 4.7.z errata that went out, so the sooner we can get this change shipped the better)

I can try. I've never done that before. Although, this needs cherry-pick approval anyway. Would it be better for the patch manager to override the invalid-bug label?

@staebler staebler removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 30, 2021
@miabbott
Copy link
Member Author

I can try. I've never done that before. Although, this needs cherry-pick approval anyway. Would it be better for the patch manager to override the invalid-bug label?

Looks like it worked! Next time I'll be more patient and wait for the patch manager.

@miabbott
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Mar 31, 2021
@openshift-ci-robot
Copy link
Contributor

@miabbott: This pull request references Bugzilla bug 1935174, which is invalid:

  • expected Bugzilla bug 1935174 to depend on a bug targeting a release in 4.8.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@miabbott: This pull request references Bugzilla bug 1935174, which is invalid:

  • expected the bug to target the "4.7.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 31, 2021
@openshift-ci-robot
Copy link
Contributor

@miabbott: This pull request references Bugzilla bug 1935174, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1934557 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1934557 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2021

@miabbott: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 2c06ddb link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fae650e into openshift:release-4.7 Apr 10, 2021
@openshift-ci-robot
Copy link
Contributor

@miabbott: All pull requests linked via external trackers have merged:

Bugzilla bug 1935174 has been moved to the MODIFIED state.

In response to this:

Bug 1935174: RHCOS bump for LUKS, prjquota, etc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants