Bug 1943500: Bump gophercloud utils #4794

mandre · 2021-03-26T09:44:30Z

Bump gophercloud/utils to include gophercloud/utils#149.

This commit ensures gophercloud keeps working fine when using a custom
CA cert and Proxy at the same time.

Bumping gophercloud utils breaks the Terraform provider, which must then
be updated. I'm pinning to the same version that we're using in 4.8.

go get github.com/gophercloud/utils
go get github.com/terraform-provider-openstack/terraform-provider-openstack@v1.37.0
go mod vendor

Incidentally, also includes the necessary code to fix https://bugzilla.redhat.com/show_bug.cgi?id=1786314 for 4.7.

Bump gophercloud/utils to include gophercloud/utils#149. This commit ensures gophercloud keeps working fine when using a custom CA cert and Proxy at the same time. Bumping gophercloud utils breaks the Terraform provider, which must then be updated. I'm pinning to the same version that we're using in 4.8. go get github.com/gophercloud/utils go get github.com/terraform-provider-openstack/terraform-provider-openstack@v1.37.0 go mod vendor

Adjust call to servergroup.List to comply with the new function signature [1]. [1]: gophercloud/gophercloud#2070

openshift-ci-robot · 2021-03-26T09:44:35Z

@mandre: This pull request references Bugzilla bug 1943500, which is invalid:

expected dependent Bugzilla bug 1925216 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1943500: Bump gophercloud utils

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

staebler · 2021-03-26T15:54:34Z

/approve

openshift-ci-robot · 2021-03-26T15:54:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

staebler · 2021-03-26T15:55:24Z

Tests that should not be required.
/override ci/prow/e2e-kubevirt
/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-vsphere-upi

openshift-ci-robot · 2021-03-26T15:55:37Z

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-kubevirt, ci/prow/e2e-metal-assisted, ci/prow/e2e-vsphere-upi

In response to this:

Tests that should not be required.
/override ci/prow/e2e-kubevirt
/override ci/prow/e2e-metal-assisted
/override ci/prow/e2e-vsphere-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2021-03-29T06:29:46Z

/recheck

mandre · 2021-03-29T16:28:23Z

/retest

EmilienM

/retest

mandre · 2021-04-08T07:07:38Z

I'm moving the 4.7 e2e-openstack job over to vexxhost with openshift/release#17543, that should hopefully get us a green CI.

mandre · 2021-04-12T15:03:07Z

/retest

mandre · 2021-05-04T09:28:49Z

/bugzilla refresh

openshift-ci-robot · 2021-05-04T09:29:02Z

@mandre: This pull request references Bugzilla bug 1943500, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1925216 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1925216 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (juriarte@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2021-05-04T09:29:49Z

/retest

mandre · 2021-05-04T12:40:08Z

Note to patch master, please ignore the e2e-openstack-ipi job, this is our step-registry job and it has never worked (we're still working on it). The e2e-openstack job was successful.

pierreprinetti · 2021-05-04T12:47:59Z

/lgtm
/label platform/openstack

openshift-bot · 2021-05-04T13:37:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T14:00:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T15:49:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T10:58:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T11:58:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T12:34:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T13:58:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T15:46:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T17:22:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T18:10:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T19:22:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-09T23:58:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T03:21:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T04:39:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T06:21:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T07:32:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T08:21:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T09:08:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T11:20:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T12:45:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

pierreprinetti · 2021-05-10T14:30:58Z

/skip e2e-openstack-ipi

pierreprinetti · 2021-05-10T14:33:29Z

/skip

openshift-bot · 2021-05-10T14:57:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-10T15:33:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

pierreprinetti · 2021-05-10T18:35:57Z

/skip

openshift-ci · 2021-05-14T01:53:09Z

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-crc	`2a9fb53`	link	`/test e2e-crc`
ci/prow/e2e-openstack-ipi	`2a9fb53`	link	`/test e2e-openstack-ipi`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pierreprinetti · 2021-05-14T07:06:42Z

/test e2e-aws

openshift-bot · 2021-05-14T07:47:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-14T08:36:40Z

@mandre: All pull requests linked via external trackers have merged:

openshift/installer#4794

Bugzilla bug 1943500 has been moved to the MODIFIED state.

In response to this:

Bug 1943500: Bump gophercloud utils

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre added 2 commits March 26, 2021 10:18

Adjust function call after gophercloud bump

2a9fb53

Adjust call to servergroup.List to comply with the new function signature [1]. [1]: gophercloud/gophercloud#2070

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 26, 2021

openshift-ci-robot requested review from adduarte and patrickdillon March 26, 2021 09:44

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2021

EmilienM reviewed Apr 8, 2021

View reviewed changes

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 4, 2021

openshift-ci-robot added the platform/openstack label May 4, 2021

openshift-ci-robot assigned pierreprinetti May 4, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021

knobunc removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 10, 2021

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 14, 2021

openshift-merge-robot merged commit 3a40433 into openshift:release-4.7 May 14, 2021

pierreprinetti deleted the gophercloud-utils-47 branch May 14, 2021 09:20

Bug 1943500: Bump gophercloud utils #4794

Bug 1943500: Bump gophercloud utils #4794

Conversation

mandre commented Mar 26, 2021

openshift-ci-robot commented Mar 26, 2021

staebler commented Mar 26, 2021

openshift-ci-robot commented Mar 26, 2021

staebler commented Mar 26, 2021

openshift-ci-robot commented Mar 26, 2021

mandre commented Mar 29, 2021

mandre commented Mar 29, 2021

EmilienM left a comment

Choose a reason for hiding this comment

mandre commented Apr 8, 2021

mandre commented Apr 12, 2021

mandre commented May 4, 2021

openshift-ci-robot commented May 4, 2021

mandre commented May 4, 2021

mandre commented May 4, 2021

pierreprinetti commented May 4, 2021

openshift-bot commented May 4, 2021

openshift-bot commented May 4, 2021

openshift-bot commented May 4, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 9, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

pierreprinetti commented May 10, 2021

pierreprinetti commented May 10, 2021

openshift-bot commented May 10, 2021

openshift-bot commented May 10, 2021

pierreprinetti commented May 10, 2021

openshift-ci bot commented May 14, 2021 • edited

pierreprinetti commented May 14, 2021

openshift-bot commented May 14, 2021

openshift-ci bot commented May 14, 2021

openshift-ci bot commented May 14, 2021 •

edited