Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1929136: OpenStack: document Manila share mounting #4803

Merged
merged 1 commit into from Jun 16, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Mar 31, 2021

No description provided.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from fedosin after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 31, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 31, 2021
@openshift-ci-robot
Copy link
Contributor

@Fedosin: This pull request references Bugzilla bug 1929136, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gcheresh@redhat.com), skipping review request.

In response to this:

Bug 1929136: OpenStack: document issues with Manila share mounting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin Fedosin changed the title Bug 1929136: OpenStack: document issues with Manila share mounting Bug 1929136: OpenStack: document Manila share mounting May 11, 2021
Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug in the manila operator, imho. It should do this automatically if required.

I'm fine documenting this as a workaround, but I think we need to open an issue against the manila operator to track it. The issue should link to this documentation with a note to remove it when the issue is resolved. Additionally, this PR should contain a link to the issue.

Copy link

@tombarron tombarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this critical bit of information, Mike! We really need to get it in front of our customers as several of them have gotten stuck at this point.

@@ -0,0 +1,35 @@
# Connecting nodes to a dedicated Manila network

If you are going to use OpenStack Manila on your cluster, you should be aware that the service usually uses a standalone network for its shares, and by default the installer does not connect nodes to this network. It causes problems with mounting shares on an already deployed cluster, as there is no route to the network:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the service usually uses a standalone network for its shares

Is it worth enumerating situations where this is not the case?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the deal. CephFS via NFS back end (Red Hat supplied) will always need this extra network connection. So will some vendor storage back ends. But vendor backends support a mode that we in Maniila call DHSS=True where the NFS server presents itself directly on the tenant network (private network where the manila client resides). In these cases no extra network is required.

@maxwelldb as you can see I don't have a crisp, succinct way to enumerate those situations but maybe you can craft something worth adding here ...

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdbooth Are you suggesting that Manila CSI operator should modify the worker VMs to connect to the manila network? Even if it had the information on which network Manila exposes its shares, it doesn't seem to be the responsibility of Manila operator to change the definition of the VMs. More the responsibility of the Machine API Operator, which is what we're documenting here.

docs/user/openstack/connect_nodes_to_manila_network.md Outdated Show resolved Hide resolved
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, tombarron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit d5a0486 into openshift:master Jun 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 1929136 has been moved to the MODIFIED state.

In response to this:

Bug 1929136: OpenStack: document Manila share mounting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants