Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: Add Unit Tests for validation of platform.openstack.machineSubnet #4937

Merged
merged 2 commits into from
Jun 21, 2021
Merged

OpenStack: Add Unit Tests for validation of platform.openstack.machineSubnet #4937

merged 2 commits into from
Jun 21, 2021

Commits on Jun 17, 2021

  1. Bug 1957809: Add Unit Tests for validation of platform.openstack.mach… 

    …ineSubnet
    @gyohuangxin
    gyohuangxin authored and xinhuang committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5dad6d2 View commit details
    Browse the repository at this point in the history

  2. Delete the duplicate logic in platform.openstack.machineSubnet 

    This link to another validation already covers the case that
both p.MachineSubnet and p.ExternalDNS are not nil, so we remove the
duplicate validation.
https://github.com/openshift/installer/blob/6d5a001/pkg/asset/installconfig/openstack/validation/platform.go#L41-L43
    @gyohuangxin
    gyohuangxin authored and xinhuang committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    b750bfd View commit details
    Browse the repository at this point in the history