Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1956483: Bump boot images for RHCOS fixes #4961

Merged
merged 1 commit into from Jun 11, 2021

Conversation

miabbott
Copy link
Member

This brings in the following fixes:

BZ 1956489 - CVE-2021-3114 ignition: golang: crypto/elliptic: incorrect operations on the P-224 curve
BZ 1960748 - RHCOS PXE deployment script coreos-livepxe-rootfs randomly fails to download and verify the image with bonding LACP active-active

Changes generated with:

$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.7/47.83.202105220305-0/x86_64/meta.json amd64
$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.7-ppc64le/47.83.202105211710-0/ppc64le/meta.json ppc64le
$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.7-s390x/47.83.202105211211-0/s390x/meta.json s390x

This brings in the following fixes:

BZ 1956489 - CVE-2021-3114 ignition: golang: crypto/elliptic: incorrect operations on the P-224 curve
BZ 1960748 - RHCOS PXE deployment script coreos-livepxe-rootfs randomly fails to download and verify the image with bonding LACP active-active

Changes generated with:

```
$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.7/47.83.202105220305-0/x86_64/meta.json amd64
$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.7-ppc64le/47.83.202105211710-0/ppc64le/meta.json ppc64le
$ hack/update-rhcos-bootimage.py https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.7-s390x/47.83.202105211211-0/s390x/meta.json s390x
```
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2021

@miabbott: This pull request references Bugzilla bug 1956483, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1956480 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1956480 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

Bug 1956483: Bump boot images for RHCOS fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member Author

/retest

@miabbott
Copy link
Member Author

e2e-openstack shows that bootstrap/master nodes were created in OpenStack, but they are all spinning on fetching the Ignition config:

[0m] A start job is running for Ignition (fetch) (22min 55s / no limit)

The logs appear to be missing any larger context for why this is occurring but it suspect there is some kind of networking issue preventing the fetch from succeeding. Without additional context, I can't understand what is going on.

e2e-crc has been perma-red in the most recent history. On this PR, it looks like a bunch of operators never succeeded; perhaps the masters never succeeded. I forget the topology of the CRC install...

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing changes to rhcos-stream.json and rhcos-aarch64.json.

@miabbott
Copy link
Member Author

This is missing changes to rhcos-stream.json and rhcos-aarch64.json.

Those files don't exist on the release-4.7 branch; I don't even think we have aarch64 builds for 4.7.

@mandre
Copy link
Member

mandre commented May 31, 2021

e2e-openstack shows that bootstrap/master nodes were created in OpenStack, but they are all spinning on fetching the Ignition config:

[0m] A start job is running for Ignition (fetch) (22min 55s / no limit)

The logs appear to be missing any larger context for why this is occurring but it suspect there is some kind of networking issue preventing the fetch from succeeding. Without additional context, I can't understand what is going on.

The infra where this job ran had an issue with their metadata service. This should be fixed now, ref https://bugzilla.redhat.com/show_bug.cgi?id=1963932.

/retest

@mandre
Copy link
Member

mandre commented May 31, 2021

/retest

@staebler
Copy link
Contributor

This is missing changes to rhcos-stream.json and rhcos-aarch64.json.

Those files don't exist on the release-4.7 branch; I don't even think we have aarch64 builds for 4.7.

Doh! Sorry, I missed that this for 4.7.

@staebler
Copy link
Contributor

staebler commented Jun 1, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2021
@miabbott
Copy link
Member Author

miabbott commented Jun 7, 2021

@staebler should I get someone else from RHCOS to give the /lgtm?

@staebler
Copy link
Contributor

staebler commented Jun 7, 2021

@staebler should I get someone else from RHCOS to give the /lgtm?

Yes, please.

@travier
Copy link
Member

travier commented Jun 7, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@gbraad
Copy link

gbraad commented Jun 10, 2021

@praveenkumar INFO[2021-06-10T02:31:56Z] scp: /home/packer/snc/*.crcbundle: No such file or directory


msg=EnvVarControllerDegraded: can't update etcd pod configurations because scaling is currently unsafe: 3 nodes are required, but only 1 are available

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@praveenkumar
Copy link
Contributor

/retest

@praveenkumar
Copy link
Contributor

Please ignore the failure for 4.7 branch, we need to update the CI job for it.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@travier
Copy link
Member

travier commented Jun 10, 2021

Can we get a CI override for this one? Thanks!

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 11, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

@miabbott: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 5e28207 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7d940d5 into openshift:release-4.7 Jun 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 11, 2021

@miabbott: All pull requests linked via external trackers have merged:

Bugzilla bug 1956483 has been moved to the MODIFIED state.

In response to this:

Bug 1956483: Bump boot images for RHCOS fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants