Bug 1974598: OpenStack: Optimize cluster deletion #5004
Conversation
mandre
force-pushed
the
openstack-optimize-destroy
branch
from
b52b342
to
7814284
Compare
|
/test e2e-openstack-ipi |
|
@mandre: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
Nice. This matches more closely the desired destroy behavior that we am for with cloud platforms. |
mandre
force-pushed
the
openstack-optimize-destroy
branch
from
7814284
to
3cb8ed4
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-ovirt Retriggering, failure due to infrastructure change |
mandre
force-pushed
the
openstack-optimize-destroy
branch
from
3cb8ed4
to
7875786
Compare
|
My test on a kuryr cluster shows a 24% improvement on the time it takes to delete a cluster, 14m37s vs 19m14s. Not as impressive as I hoped it would be but still nice to take. |
Wow !! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mandre
changed the title
openshift-ci
bot
added
bugzilla/severity-medium
|
@mandre: This pull request references Bugzilla bug 1974598, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
Previously each destroy function would exit on the first conflict and it was expected to retry on a next iteration, hoping that in the mean time the conflict that prevented removal of the resource was fixed. While this strategy works, it is also slower then necessary. A better strategy is to try deleting all resources and ignore the ones that have conflicts. On the next iteration there will be less conflicts. This patch was tested on a openstack cluster with openshiftSDN, and we observed a 37% faster cluster deletion. I expect the performance boost to be significantly higher for clusters using kuryr.
mandre
force-pushed
the
openstack-optimize-destroy
branch
from
7875786
to
375fe6f
Compare
|
/lgtm |
openshift-merge-robot
removed
the
needs-rebase
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@mandre: All pull requests linked via external trackers have merged: Bugzilla bug 1974598 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously each destroy function would exit on the first conflict and
it was expected to retry on a next iteration, hoping that in the mean
time the conflict that prevented removal of the resource was fixed.
While this strategy works, it is also slower then necessary. A better
strategy is to try deleting all resources and ignore the ones that have
conflicts. On the next iteration there will be less conflicts.
This patch was tested on a openstack cluster with openshiftSDN, and
we observed a 37% faster cluster deletion. I expect the performance
boost to be significantly higher for clusters using kuryr.