OpenStack: explicitly disable octavia when using kuryr #5047
Conversation
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Kuryr already handles the service type Load Balancer and we need to explicitly disable the use of octavia in the cloud provider configuration otherwise we'll run into issues once the default for `use-octavia` changes from false to true with the out-of-tree openstack cloud provider. Implements OSASINFRA-2510.
Use octavia if available, unless using kuryr. There should be no penalty for setting `use-octavia` in your cloud configuration even when octavia is not available in the environment. Many people didn't realize they needed to enable the octavia integration as a day 2 operation if they wanted to use LB type services on an OpenStack platform. This is now performed for them at install time and is less disruptive for the cluster. Also, in the event the cloud platform gains the Octavia service after the initial installation, then the openshift cluster should be able to use it out of the box.
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Looks good to me. Just a side note, this config won't be enforced to False in case the user attempts to set it to True, right? |
Just like today, the user can change the cloud provider configuration, either:
Nothing was changed in that regard, we don't perform validation for the above. The patch only changes the default configuration to match more closely the environment on which the user deploys.
I've just added a note in the 4.9 release note tracker, thanks for the reminder. |
|
/lgtm |
|
/assign @iamemilio |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Kuryr already handles the service type Load Balancer and we need to
explicitly disable the use of octavia in the cloud provider
configuration otherwise we'll run into issues once the default for
use-octaviachanges from false to true with the out-of-tree openstackcloud provider.
Implements OSASINFRA-2510