Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1970179: update boot images for RHCOS 4.9 #5049

Merged
merged 2 commits into from Jul 21, 2021

Conversation

miabbott
Copy link
Member

@miabbott miabbott commented Jul 1, 2021

This brings in properly identified RHCOS 4.9 boot images for all
architectures. In addition, the following BZs are addressed:

1959248 - CVE-2021-31525 ignition: golang: net/http: panic in ReadRequest and ReadResponse when reading a very large header
1960485 - Cannot use DASD at virtio block device when installing RHCOS on KVM

aarch64=49.84.202106302247-0
ppc64le=49.84.202107010047-0
s390x=49.84.202106302347-0
x86_64=49.84.202107010027-0

$ plume cosa2stream --target=data/data/rhcos-stream.json --distro=rhcos aarch64=49.84.202106302247-0 ppc64le=49.84.202107010047-0 s390x=49.84.202106302347-0 x86_64=49.84.202107010027-0
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9-aarch64/49.84.202106302247-0/aarch64/meta.json aarch64
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9/49.84.202107010027-0/x86_64/meta.json amd64
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9-ppc64le/49.84.202107010047-0/ppc64le/meta.json ppc64le
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9-s390x/49.84.202106302347-0/s390x/meta.json s390x

hack/update-rhcos-bootimage.py: update RHCOS_RELEASES_APP

I think this was supposed to be part of #4928.

(cherry picked from commit f916530)

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

@miabbott: This pull request references Bugzilla bug 1970179, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1970179: update boot images for RHCOS 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 1, 2021
@openshift-ci openshift-ci bot requested review from jhixson74 and jstuever July 1, 2021 15:19
@miabbott
Copy link
Member Author

miabbott commented Jul 1, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

@miabbott: This pull request references Bugzilla bug 1970179, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 1, 2021
@openshift-ci openshift-ci bot requested a review from mike-nguyen July 1, 2021 15:20
@miabbott
Copy link
Member Author

miabbott commented Jul 1, 2021

/retest

1 similar comment
@travier
Copy link
Member

travier commented Jul 7, 2021

/retest

@travier
Copy link
Member

travier commented Jul 7, 2021

/assign travier

@travier
Copy link
Member

travier commented Jul 7, 2021

/test e2e-aws-workers-rhel7

@travier
Copy link
Member

travier commented Jul 7, 2021

/test e2e-metal-ipi-ovn-ipv6

@travier
Copy link
Member

travier commented Jul 7, 2021

/test e2e-aws-workers-rhel7

@travier
Copy link
Member

travier commented Jul 8, 2021

/test e2e-aws-workers-rhel7
/test e2e-metal-ipi-ovn-ipv6

@miabbott
Copy link
Member Author

e2e-crc has been failing or flaky at best in recent history; I don't believe this PR has changed anything to that effect.

e2e-aws-workers-rhel7 has also been failing or flaky since before this PR was proposed.

e2e-metal-ipi-ovn-ipv6 has been spotty: some success, lots of failure, lots of flakes. The most recent failures seen on this PR look like it might be https://bugzilla.redhat.com/show_bug.cgi?id=1957886

Filed https://bugzilla.redhat.com/show_bug.cgi?id=1981867 for the oc explain failure on that job.

/assign @patrickdillon

@patrickdillon
Copy link
Contributor

AzureStack images have not been included due to an upstream issue captured here: coreos/stream-metadata-go#26 (comment)

The streams should be regenerated after the two dependent PRs, coreos/coreos-assembler#2303 & coreos/stream-metadata-go#27, merge.

I think this was supposed to be part of openshift#4928.

(cherry picked from commit f916530)
@patrickdillon
Copy link
Contributor

@miabbott dependent PRs for azurestack support have merged

This brings in properly identified RHCOS 4.9 boot images for all
architectures.  In addition, the following BZs are addressed:

1959248 - CVE-2021-31525 ignition: golang: net/http: panic in ReadRequest and ReadResponse when reading a very large header
1960485 - Cannot use DASD at virtio block device when installing RHCOS on KVM

aarch64=49.84.202106302247-0
ppc64le=49.84.202107010047-0
s390x=49.84.202106302347-0
x86_64=49.84.202107010027-0

```
$ plume cosa2stream --target=data/data/rhcos-stream.json --distro=rhcos aarch64=49.84.202106302247-0 ppc64le=49.84.202107010047-0 s390x=49.84.202106302347-0 x86_64=49.84.202107010027-0
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9-aarch64/49.84.202106302247-0/aarch64/meta.json aarch64
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9/49.84.202107010027-0/x86_64/meta.json amd64
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9-ppc64le/49.84.202107010047-0/ppc64le/meta.json ppc64le
$ hack/update-rhcos-bootimage.py https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases/rhcos-4.9-s390x/49.84.202106302347-0/s390x/meta.json s390x
```
@miabbott
Copy link
Member Author

Pushed update with azurestack added to the stream metadata ⬆️

@miabbott
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

@miabbott: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 29c00b3 link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc 29c00b3 link /test e2e-crc
ci/prow/e2e-ovirt 29c00b3 link /test e2e-ovirt
ci/prow/e2e-libvirt 29c00b3 link /test e2e-libvirt
ci/prow/e2e-aws-workers-rhel7 29c00b3 link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-single-node 29c00b3 link /test e2e-aws-single-node
ci/prow/e2e-openstack-kuryr 29c00b3 link /test e2e-openstack-kuryr

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve
/lgtm

Thanks for taking care of ASH so quickly.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 4e24971 into openshift:master Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

@miabbott: All pull requests linked via external trackers have merged:

Bugzilla bug 1970179 has been moved to the MODIFIED state.

In response to this:

Bug 1970179: update boot images for RHCOS 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants