Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baremetal: Update IPI docs for latest version #5054

Merged
merged 1 commit into from Jul 7, 2021
Merged

baremetal: Update IPI docs for latest version #5054

merged 1 commit into from Jul 7, 2021

Conversation

hardys
Copy link
Contributor

@hardys hardys commented Jul 2, 2021

BM IPI is no longer experimental, and some of the content is no
longer accurate, this PR does a first-pass update of the content.

@hardys hardys requested a review from stbenjam July 2, 2021 13:24
@openshift-ci openshift-ci bot requested a review from jhixson74 July 2, 2021 13:24
@hardys
Copy link
Contributor Author

hardys commented Jul 2, 2021

/label platform/baremetal

@openshift-ci openshift-ci bot added the platform/baremetal IPI bare metal hosts platform label Jul 2, 2021
@stbenjam
Copy link
Member

stbenjam commented Jul 2, 2021

/lgtm
/assign @patrickdillon

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2021
baremetal: Update IPI docs for latest version
ca29013 
BM IPI is no longer experimental, and some of the content is no
longer accurate, this PR does a first-pass update of the content.
@hardys
Copy link
Contributor Author

hardys commented Jul 5, 2021

I noticed a markdown issue with the table formatting for bootMode, now fixed

@stbenjam
Copy link
Member

stbenjam commented Jul 6, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2021
@sadasu
Copy link
Contributor

sadasu commented Jul 6, 2021

/lgtm

@jhixson74
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2021 •
edited

@hardys: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-workers-rhel7 ca29013 link /test e2e-aws-workers-rhel7
ci/prow/e2e-crc ca29013 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c3ac937 into openshift:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@stbenjam stbenjam

@sadasu sadasu

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hardys @stbenjam @sadasu @jhixson74 @openshift-bot @patrickdillon @openshift-merge-robot