Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibmcloud: Update security groups and rules #5059

Merged
merged 3 commits into from Jul 16, 2021
Merged

ibmcloud: Update security groups and rules #5059

merged 3 commits into from Jul 16, 2021

Conversation

hasueki
Copy link
Contributor

@hasueki hasueki commented Jul 7, 2021

Define more IBM Cloud VPC security groups and rules, following the documentation for OCP networking requirements. This also updates the set of security groups to attach to the nodes defined in Terraform and Machine/MachineSet CRs.

@hasueki
Copy link
Contributor Author

hasueki commented Jul 7, 2021

/assign @jstuever

@hasueki
Copy link
Contributor Author

hasueki commented Jul 8, 2021

/retest

jstuever
jstuever requested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@jstuever jstuever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the difference between cluster-wide and openshift-network security groups. They feel redundant and can probably be collapsed into one.

Other than this, a few minor adjustments to tighten security a bit.

data/data/ibmcloud/vpc/security-groups.tf Outdated Show resolved Hide resolved
data/data/ibmcloud/vpc/security-groups.tf Outdated Show resolved Hide resolved
data/data/ibmcloud/vpc/security-groups.tf Outdated Show resolved Hide resolved
@hasueki
Copy link
Contributor Author

hasueki commented Jul 14, 2021 •
edited

@jstuever

Can you explain the difference between cluster-wide and openshift-network security groups. They feel redundant and can probably be collapsed into one.

There is a limitation in IBM Cloud VPC security groups where only 5 remote rules are configurable per security group. With that, I needed to separate it into 2 security groups and tried to organize it in a way that makes the most sense.

@hasueki hasueki requested a review from jstuever July 14, 2021 20:44
@jstuever
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 15, 2021
@jstuever
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021 •
edited

@hasueki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-kuryr 4d91d63 link /test e2e-openstack-kuryr
ci/prow/e2e-aws-workers-rhel7 4d91d63 link /test e2e-aws-workers-rhel7
ci/prow/e2e-openstack 4d91d63 link /test e2e-openstack
ci/prow/e2e-crc 4d91d63 link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7765195 into openshift:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever jstuever approved these changes

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@jstuever jstuever

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hasueki @jstuever @openshift-merge-robot