Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update baremetal-operator v0.0.0-20210706141527-5240e42f012a #5061

Merged
merged 1 commit into from Jul 21, 2021
Merged

vendor: update baremetal-operator v0.0.0-20210706141527-5240e42f012a #5061

merged 1 commit into from Jul 21, 2021

Conversation

derekhiggins
Copy link
Contributor

@derekhiggins derekhiggins commented Jul 7, 2021 •
edited

Specifically looking to include metal3-io/baremetal-operator#853
which will allow baremetal nodes to be provisioned with ipmi when
full Administrator BMC credentials arn't available.

Also had to add a new entry in the replace section for "baremetal-operator/apis"
to allow for a change in the way BMO vendors this in.

@openshift-ci openshift-ci bot requested review from jstuever and mtnbikenc July 7, 2021 16:11
@derekhiggins
Copy link
Contributor Author

/test e2e-libvirt
/test e2e-aws-workers-rhel7

@derekhiggins
Copy link
Contributor Author

/test e2e-crc
/test e2e-openstack

@derekhiggins
Copy link
Contributor Author

/test e2e-libvirt
/test e2e-aws-workers-rhel7
/test e2e-crc

@derekhiggins
Copy link
Contributor Author

/test e2e-libvirt

@hardys
Copy link
Contributor

hardys commented Jul 9, 2021

/label platform/baremetal

@openshift-ci openshift-ci bot added the platform/baremetal IPI bare metal hosts platform label Jul 9, 2021
@hardys
Copy link
Contributor

hardys commented Jul 9, 2021

/approve

@hardys
Copy link
Contributor

hardys commented Jul 9, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2021
@imain
Copy link
Contributor

imain commented Jul 19, 2021

lgtm

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@derekhiggins
vendor: update baremetal-operator v0.0.0-20210706141527-5240e42f012a
dad9901 
Specifically looking to include metal3-io/baremetal-operator#853
which will allow baremetal nodes to be provisioned with ipmi when
full Administrator BMC credentials arn't available.

Also had to add a new entry in the replace section for "baremetal-operator/apis"
to allow for a change in the way BMO vendors this in.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021 •
edited

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-kuryr dad9901 link /test e2e-openstack-kuryr
ci/prow/e2e-aws-workers-rhel7 dad9901 link /test e2e-aws-workers-rhel7
ci/prow/e2e-crc dad9901 link /test e2e-crc
ci/prow/e2e-metal-ipi-ovn-ipv6 dad9901 link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@derekhiggins
Copy link
Contributor Author

/retest-required

@hardys
Copy link
Contributor

hardys commented Jul 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 200a78f into openshift:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@hardys hardys

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@derekhiggins @hardys @imain @patrickdillon @openshift-bot @openshift-merge-robot