Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baremetal: Split terraform into stages #5064

Merged
merged 1 commit into from Dec 14, 2021
Merged

Baremetal: Split terraform into stages #5064

merged 1 commit into from Dec 14, 2021

Conversation

jhixson74
Copy link
Member

bootstrap: create bootstrap resources
masters: create permanent cluster resources

This is needed for Terraform v0.14.6 and later since Terraform deletions now
destroy all resource dependencies.

https://issues.redhat.com/browse/CORS-1697

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2021
@openshift-ci openshift-ci bot requested review from jstuever and markmc July 8, 2021 21:25
@jhixson74 jhixson74 force-pushed the master_terraform_split_baremetal branch from 0ce7c2e to 1859443 Compare July 8, 2021 21:25
@jhixson74
Copy link
Member Author

/test e2e-metal

@jhixson74 jhixson74 force-pushed the master_terraform_split_baremetal branch from 1859443 to 60c0546 Compare July 8, 2021 21:39
@jhixson74
Copy link
Member Author

/retest

@jhixson74 jhixson74 force-pushed the master_terraform_split_baremetal branch from 60c0546 to ec33149 Compare July 9, 2021 01:22
@hardys
Copy link
Contributor

hardys commented Jul 9, 2021

@stbenjam we talked about doing this previously, could you take a look please? Thanks!

@hardys
Copy link
Contributor

hardys commented Jul 9, 2021

/cc @stbenjam @sadasu @kirankt

@hardys
Copy link
Contributor

hardys commented Jul 9, 2021 •
edited

/test e2e-metal

I think this is a UPI test, the e2e-metal-ipi-ovn-ipv6 job is the one to prove this is working

@jhixson74 jhixson74 force-pushed the master_terraform_split_baremetal branch from ec33149 to dd8d656 Compare July 9, 2021 18:13
@jhixson74 jhixson74 changed the title WIP: Baremetal: Split terraform into stages Baremetal: Split terraform into stages Jul 9, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
@jhixson74
Copy link
Member Author

/retest e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

@jhixson74: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-proxy
  • /test e2e-aws-rhel8
  • /test e2e-aws-shared-vpc
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upi
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-resourcegroup
  • /test e2e-azure-shared-vpc
  • /test e2e-azure-upi
  • /test e2e-crc
  • /test e2e-gcp
  • /test e2e-gcp-shared-vpc
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi
  • /test e2e-gcp-upi-xpn
  • /test e2e-kubevirt
  • /test e2e-libvirt
  • /test e2e-metal
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-openstack-upi
  • /test e2e-ovirt
  • /test e2e-vsphere
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-fmt
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

Use /test all to run the following jobs:

  • pull-ci-openshift-installer-master-e2e-aws
  • pull-ci-openshift-installer-master-e2e-aws-fips
  • pull-ci-openshift-installer-master-e2e-aws-upgrade
  • pull-ci-openshift-installer-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-installer-master-e2e-crc
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-installer-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-installer-master-e2e-openstack
  • pull-ci-openshift-installer-master-e2e-ovirt
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-openstack-manifests
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/retest e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jhixson74
Copy link
Member Author

/retest

@jhixson74 jhixson74 changed the title Baremetal: Split terraform into stages WIP: Baremetal: Split terraform into stages Jul 9, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
@jhixson74 jhixson74 force-pushed the master_terraform_split_baremetal branch 6 times, most recently from 1a18ffe to 2322f8d Compare July 14, 2021 15:25
@jhixson74
Copy link
Member Author

jhixson74 commented Jul 15, 2021 •
edited

/test e2e-metal-ipi-ovn-ipv6

@staebler staebler mentioned this pull request Dec 13, 2021
Merged
@jhixson74
Baremetal: Split terraform into stages
620dc71 
bootstrap: create bootstrap resources
masters: create permanent cluster resources

This is needed for Terraform v0.14.6 and later since Terraform deletions now
destroy all resource dependencies.

https://issues.redhat.com/browse/CORS-1697
@jhixson74 jhixson74 force-pushed the master_terraform_split_baremetal branch from 6dd7954 to 620dc71 Compare December 13, 2021 18:15
staebler
staebler approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2021

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal 60c0546 link /test e2e-metal
ci/prow/e2e-openstack-byon 6838727 link /test e2e-openstack-byon
ci/prow/e2e-aws-fips 620dc71 link false /test e2e-aws-fips
ci/prow/e2e-aws-single-node 620dc71 link false /test e2e-aws-single-node
ci/prow/e2e-ovirt 620dc71 link false /test e2e-ovirt
ci/prow/e2e-metal-ipi 620dc71 link false /test e2e-metal-ipi
ci/prow/e2e-crc 620dc71 link false /test e2e-crc
ci/prow/okd-e2e-aws-upgrade 620dc71 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-aws-workers-rhel7 620dc71 link false /test e2e-aws-workers-rhel7
ci/prow/e2e-openstack-kuryr 620dc71 link false /test e2e-openstack-kuryr
ci/prow/e2e-libvirt 620dc71 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9c46272 into openshift:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardys hardys hardys left review comments

@jstuever jstuever jstuever left review comments

@staebler staebler staebler approved these changes

@markmc markmc Awaiting requested review from markmc

@kirankt kirankt Awaiting requested review from kirankt

@sadasu sadasu Awaiting requested review from sadasu

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@stbenjam stbenjam

@staebler staebler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jhixson74 @hardys @stbenjam @zaneb @staebler @openshift-bot @jstuever @kirankt @openshift-merge-robot