Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubevirt: Split terraform into stages #5068

Closed

Conversation

jhixson74
Copy link
Member

@jhixson74 jhixson74 commented Jul 9, 2021

masters: create permanent cluster resources
bootstrap: create datavolume & bootstrap resources

This is needed for Terraform v0.14.6 and later since Terraform deletions now
destroy all resource dependencies.

https://issues.redhat.com/browse/CORS-1698

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jhixson74 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from jstuever and nirarg July 9, 2021 22:13
@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch 2 times, most recently from cc44232 to 0d2262a Compare July 14, 2021 05:24
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch from 0d2262a to b6eefd0 Compare July 15, 2021 06:32
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

1 similar comment
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@jhixson74 jhixson74 changed the title WIP: Kubevirt: Split terraform into stages Kubevirt: Split terraform into stages Jul 15, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2021
@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch from b6eefd0 to 9d802ea Compare August 4, 2021 19:33
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch 2 times, most recently from 8dd64a5 to 03dee87 Compare August 5, 2021 21:54
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch from 03dee87 to 15c82a2 Compare August 5, 2021 23:17
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

2 similar comments
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch from 15c82a2 to baa7d88 Compare August 17, 2021 18:16
@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch from baa7d88 to 570fecf Compare September 16, 2021 00:17
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch from 570fecf to 10c720a Compare September 21, 2021 21:31
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

masters: create permanent cluster resources
bootstrap: create data volume & bootstrap resources

This is needed for Terraform v0.14.6 and later since Terraform deletions now
destroy all resource dependencies.

https://issues.redhat.com/browse/CORS-1698
@jhixson74 jhixson74 force-pushed the master_terraform_split_kubevirt branch from 10c720a to d09ba5b Compare October 19, 2021 23:15
@jhixson74
Copy link
Member Author

/test e2e-kubevirt

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2021

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-byon baa7d88 link /test e2e-openstack-byon
ci/prow/govet d09ba5b link true /test govet
ci/prow/unit d09ba5b link true /test unit
ci/prow/okd-unit d09ba5b link true /test okd-unit
ci/prow/e2e-aws d09ba5b link true /test e2e-aws
ci/prow/e2e-aws-workers-rhel7 d09ba5b link false /test e2e-aws-workers-rhel7
ci/prow/e2e-kubevirt d09ba5b link false /test e2e-kubevirt
ci/prow/images d09ba5b link true /test images
ci/prow/e2e-metal-ipi-ovn-ipv6 d09ba5b link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-crc d09ba5b link false /test e2e-crc
ci/prow/e2e-aws-fips d09ba5b link false /test e2e-aws-fips
ci/prow/e2e-openstack d09ba5b link false /test e2e-openstack
ci/prow/e2e-ovirt d09ba5b link false /test e2e-ovirt
ci/prow/e2e-aws-single-node d09ba5b link false /test e2e-aws-single-node
ci/prow/e2e-libvirt d09ba5b link false /test e2e-libvirt
ci/prow/e2e-metal-single-node-live-iso d09ba5b link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-aws-workers-rhel8 d09ba5b link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-upgrade d09ba5b link true /test e2e-aws-upgrade
ci/prow/e2e-openstack-kuryr d09ba5b link false /test e2e-openstack-kuryr
ci/prow/openstack-manifests d09ba5b link true /test openstack-manifests
ci/prow/okd-images d09ba5b link true /test okd-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler
Copy link
Contributor

The kubevirt platform is being removed. See #5301.

@jhixson74
Copy link
Member Author

The kubevirt platform is being removed. See #5301.

@jhixson74 jhixson74 closed this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants