Bug 1882490: data/azure/master: Add dash to nic name

[mtnbikenc]

Fix code consistency issue of missing dash in nic name.

> $ git grep '${var.cluster_id}-master-${count.index}' | wc -l
21

> $ git grep '${var.cluster_id}-master${count.index}' | wc -l 
1

[openshift-ci]

@mtnbikenc: This pull request references Bugzilla bug 1882490, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1882490: data/azure/master: Add dash to nic name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtnbikenc]

/bugzilla refresh

[openshift-ci]

@mtnbikenc: This pull request references Bugzilla bug 1882490, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (tsze@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rna-afk]

/test e2e-azure

[jhixson74]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• data/data/azure/OWNERS [jhixson74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mjudeikis]

Appreciate the change but before we go this path I want to understand how this is aligned with other teams involved:

1. What is the plan to align existing clusters to this change?
2. How do we track which cluster "architecture" it is in the cluster itself? ARO has a metadata internally but this now makes it 3rd iteration of "Infrastructure changes".
3. How this will play in the long run when you have 2 types of NICs out there and you need to manage loadbalancers memberships? How this is aligned to MachineAPI as they potentially now will have to deal with 3 Azure architectures in the wild:
   3.1 Single and multiple NGS (change done long ago)
   3.2 Nic names prior this PR
   3.3 Nic names after this PR

Basically blind changes like this creates much more complex work for downstream components and it would be good to align this in some way.

cc @JoelSpeed

[mtnbikenc]

I will bring this up with the team.
/hold

[sdodson]

@mjudeikis What specifically would you like for the Installer to do with your bug then? Your concern is that we're not coordinating with the cloud infra team to ensure that these remain stable from this point forward? The installer has zero post install responsibilities so I don't think there's any room for the Installer to alter existing clusters, you could certainly roll through each cluster and replace masters until everything converges and you'd never have to know the existing nic naming scheme in order to do that.

[sdodson]

/lgtm cancel
/approve cancel
Clearing these so someone doesn't inadvertently let this merge by clearing the hold only.

[JoelSpeed]

AFAIK this should be safe with respect to MAPI. We only care about the NicName during VM creation, in which case we generate it with https://github.com/openshift/cluster-api-provider-azure/blob/master/pkg/cloud/azure/defaults.go#L128-L130.

When we are updating or deleting VMs, we look up the NIC that is attached to the VM, we don't guess its name based on a pattern or anything.

LGTM from me on this front at least

[mjudeikis]

@sdodson My general worry is just about the fact that installer does not have any responsibilities day 2. We already seen multiple cases where now we have 4-5 different flavors of clusters out in the wild, and this would be adding one more.

In general this is a problem which is being pushed down the queue to the last standing person in the line. In most cases its CEE, customer or SRE's.
At some point we need to stop doing this and start tracking changes in some architecture version per components so at any point in time any component interacting with other component would know which version of resource it need to talk to and how to interact with.

[sdodson]

@mjudeikis I think that's a worthwhile gap to identify but I don't think it will be addressed within the scope of a bug or a PR, or even by the Installre team. So need a decision on whether we close this PR and the BZ or we merge this and fix the bug. That decision shouldn't be influenced by whether or not we decide to start tracking and remediating architectural drift.

[mjudeikis]

@sdodson I say merge, but all this is creating quite a tech dept for teams outside AOS... just saying...

[mtnbikenc]

@sdodson @mjudeikis , Where do we stand on this PR? I'm happy to move forward or close this and the bug as WONTFIX. I'll rebase this in the meantime.

[sdodson]

We'll move forward with the change.
/lgtm
/hold cancel

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[sdodson]

/test e2e-azure

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[sdodson]

/test e2e-azure

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@mtnbikenc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-fips	9268ffe	link	/test e2e-aws-fips
ci/prow/e2e-crc	9268ffe	link	/test e2e-crc
ci/prow/e2e-libvirt	9268ffe	link	/test e2e-libvirt
ci/prow/e2e-openstack-kuryr	9268ffe	link	/test e2e-openstack-kuryr
ci/prow/e2e-aws-workers-rhel7	9268ffe	link	/test e2e-aws-workers-rhel7
ci/prow/e2e-aws-single-node	9268ffe	link	/test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[sdodson]

/override ci/prow/e2e-aws-upgrade
This only affects azure

[openshift-ci]

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws-upgrade
This only affects azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@mtnbikenc: All pull requests linked via external trackers have merged:

• openshift/installer#5082

Bugzilla bug 1882490 has been moved to the MODIFIED state.

In response to this:

Bug 1882490: data/azure/master: Add dash to nic name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.