Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibmcloud: Destroy cluster #5099

Merged
merged 3 commits into from Jul 24, 2021
Merged

ibmcloud: Destroy cluster #5099

merged 3 commits into from Jul 24, 2021

Conversation

BobbyRadford
Copy link
Contributor

@BobbyRadford BobbyRadford commented Jul 21, 2021 •
edited

Remove all IBM Cloud resources that are created with an OpenShift cluster.

hasueki
hasueki suggested changes Jul 21, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
pkg/destroy/ibmcloud/cloudobjectstorage.go Outdated Show resolved Hide resolved
pkg/destroy/ibmcloud/dns.go Outdated Show resolved Hide resolved
pkg/destroy/ibmcloud/ibmcloud.go Show resolved Hide resolved
pkg/destroy/ibmcloud/instance.go Outdated Show resolved Hide resolved
pkg/destroy/ibmcloud/vpc.go Outdated Show resolved Hide resolved
@BobbyRadford
Copy link
Contributor Author

/assign @jstuever

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@hasueki
Copy link
Contributor

hasueki commented Jul 23, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

@hasueki: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@fabianofranz
Copy link
Member

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021 •
edited

@BobbyRadford: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 24c3d0c link /test e2e-crc
ci/prow/e2e-openstack-kuryr 24c3d0c link /test e2e-openstack-kuryr
ci/prow/e2e-ovirt 24c3d0c link /test e2e-ovirt
ci/prow/e2e-libvirt 24c3d0c link /test e2e-libvirt
ci/prow/e2e-aws-workers-rhel7 24c3d0c link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-fips 24c3d0c link /test e2e-aws-fips
ci/prow/e2e-openstack 24c3d0c link /test e2e-openstack
ci/prow/e2e-aws-single-node 24c3d0c link /test e2e-aws-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6 24c3d0c link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fabianofranz
Copy link
Member

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit b5c77e1 into openshift:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki hasueki requested changes

@gsrajpal gsrajpal gsrajpal left review comments

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@patrickdillon patrickdillon

@jstuever jstuever

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@BobbyRadford @patrickdillon @hasueki @fabianofranz @gsrajpal @jstuever @openshift-merge-robot