Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/asset/manifests/dns: don't create private zone in Azure Stack #5104

Merged
merged 1 commit into from Jul 23, 2021
Merged

pkg/asset/manifests/dns: don't create private zone in Azure Stack #5104

merged 1 commit into from Jul 23, 2021

Conversation

patrickdillon
Copy link
Contributor

Skip adding private DNS zones to the DNS manifest for Azure Stack so the ingress controller does not try to create DNS records in private zones, which don't exist in ASH.

Example manifest for Azure Stack:

$ cat ash-manifests/m/manifests/cluster-dns-02-config.yml 
apiVersion: config.openshift.io/v1
kind: DNS
metadata:
  creationTimestamp: null
  name: cluster
spec:
  baseDomain: pddimg.ppe.azurestack.devcluster.openshift.com
  publicZone:
    id: /subscriptions/e90a4bc2-2f4e-4d36-874b-9011e4734d74/resourceGroups/openshiftInstallerRG/providers/Microsoft.Network/dnszones/ppe.azurestack.devcluster.openshift.com
status: {}

Example manifest for Azure:

$ cat azure-man/manifests/cluster-dns-02-config.yml 
apiVersion: config.openshift.io/v1
kind: DNS
metadata:
  creationTimestamp: null
  name: cluster
spec:
  baseDomain: padillon.installer-azure.devcluster.openshift.com
  privateZone:
    id: /subscriptions/433715e6-37fe-4328-af75-3661e13b15fc/resourceGroups/padillon-wbxr7-rg/providers/Microsoft.Network/privateDnsZones/padillon.installer-azure.devcluster.openshift.com
  publicZone:
    id: /subscriptions/433715e6-37fe-4328-af75-3661e13b15fc/resourceGroups/os4-common/providers/Microsoft.Network/dnszones/installer-azure.devcluster.openshift.com
status: {}

cc @Miciah

@patrickdillon
pkg/asset/manifests/dns: don't create private zone in Azure Stack
298c750 
Skip adding private DNS zones to the DNS manifest for Azure Stack so the
ingress controller does not try to create DNS records in private zones,
which don't exist in ASH.
@openshift-ci openshift-ci bot requested review from mtnbikenc and rna-afk July 23, 2021 01:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021 •
edited

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack-kuryr 298c750 link /test e2e-openstack-kuryr
ci/prow/e2e-crc 298c750 link /test e2e-crc
ci/prow/e2e-libvirt 298c750 link /test e2e-libvirt
ci/prow/e2e-aws-workers-rhel7 298c750 link /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-single-node 298c750 link /test e2e-aws-single-node
ci/prow/e2e-metal-ipi-ovn-ipv6 298c750 link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-openstack 298c750 link /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rna-afk
Copy link
Contributor

rna-afk commented Jul 23, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@patrickdillon
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e3301dc into openshift:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@rna-afk rna-afk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patrickdillon @rna-afk @openshift-bot @openshift-merge-robot