Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1999119: bump to golang-1.16 #5120

Merged
merged 1 commit into from Aug 31, 2021
Merged

Bug 1999119: bump to golang-1.16 #5120

merged 1 commit into from Aug 31, 2021

Conversation

eslutsky
Copy link
Contributor

@eslutsky eslutsky commented Aug 2, 2021

We need the support of the new features in the component.

Signed-off-by: Evgeny Slutsky eslutsky@redhat.com

@eslutsky
Copy link
Contributor Author

eslutsky commented Aug 2, 2021

this change also requires bumping the golang build container image to 1.16

@eslutsky eslutsky force-pushed the bump-cluster-api-provider branch 2 times, most recently from 6efb896 to 74a23b4 Compare August 9, 2021 14:04
@Gal-Zaidman
Copy link
Contributor

/retest

@eslutsky eslutsky changed the title ovirt: bump cluster provider golang-1.16 and ovirt cluster provider bump Aug 10, 2021
@eslutsky
Copy link
Contributor Author

/assign @openshift/openshift-team-installer-maintainers

@eslutsky
Copy link
Contributor Author

/assign @jstuever

@Gal-Zaidman
Copy link
Contributor

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2021
@Gal-Zaidman
Copy link
Contributor

/assign @abhinavdahiya @patrickdillon

@patrickdillon
Copy link
Contributor

If we are going to bump golang version in this PR it should be a separate commit.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@eslutsky
Copy link
Contributor Author

If we are going to bump golang version in this PR it should be a separate commit.

done

@Gal-Zaidman
Copy link
Contributor

/test e2e-ovirt

@Gal-Zaidman
Copy link
Contributor

/retest

patrickdillon
patrickdillon reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 1.16 this should also update hack/build.sh and the dockerfiles. If this turns out to be too much work let me know and we can open a separate pr

go.sum Show resolved Hide resolved
go.sum Show resolved Hide resolved
go.sum Show resolved Hide resolved
@eslutsky eslutsky changed the title golang-1.16 and ovirt cluster provider bump bump to golang-1.16 Aug 23, 2021
@eslutsky
Copy link
Contributor Author

For 1.16 this should also update hack/build.sh and the dockerfiles. If this turns out to be too much work let me know and we can open a separate pr

it does get bigger .. lets separate this PR from bumping the cluster-api-provider which depends on it.

@Gal-Zaidman
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 30, 2021
@patrickdillon
Copy link
Contributor

This still needs to update: docs/dev/dependencies.md and hack/build.sh

I am using 46a5f49 as a reference

@patrickdillon
Copy link
Contributor

Everything else looks good. I think the changes to go.sum must be an artifact of the upgrade. I tried it out locally.

@eslutsky eslutsky force-pushed the bump-cluster-api-provider branch 2 times, most recently from 88df618 to f93e1f6 Compare August 30, 2021 14:19
@eslutsky
Copy link
Contributor Author

This still needs to update: docs/dev/dependencies.md and hack/build.sh

I am using 46a5f49 as a reference

done

@eslutsky
Copy link
Contributor Author

Everything else looks good. I think the changes to go.sum must be an artifact of the upgrade. I tried it out locally.

done

@patrickdillon patrickdillon mentioned this pull request Aug 30, 2021
Closed
@LorbusChris
Copy link
Member

One should be able to fix the failing verify-vendor test by running (with a Go 1.16 binary) and committing the output of go mod tidy && go mod vendor on this branch.

@patrickdillon
Copy link
Contributor

Everything else looks good. I think the changes to go.sum must be an artifact of the upgrade. I tried it out locally.

done

Apologies if my quoted comment was unclear. I was trying to say that go.sum should indeed be included. If you re-include it in your pr, verify vendor should pass.

/approve

@patrickdillon
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

@patrickdillon: This pull request references Bugzilla bug 1999119, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gpei@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eslutsky
Bump golang to version 1.16
f821cbe 
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@patrickdillon
Copy link
Contributor

/lgtm

@patrickdillon patrickdillon mentioned this pull request Aug 31, 2021
Closed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@eslutsky: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-single-node f821cbe link /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel8 f821cbe link /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-workers-rhel7 f821cbe link /test e2e-aws-workers-rhel7
ci/prow/e2e-metal-ipi-ovn-ipv6 f821cbe link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-openstack-provider-network f821cbe link /test e2e-openstack-provider-network
ci/prow/e2e-openstack-byon f821cbe link /test e2e-openstack-byon
ci/prow/e2e-crc f821cbe link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4050517 into openshift:master Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@eslutsky: All pull requests linked via external trackers have merged:

Bugzilla bug 1999119 has been moved to the MODIFIED state.

In response to this:

Bug 1999119: bump to golang-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hardys pushed a commit to hardys/dev-scripts that referenced this pull request Sep 1, 2021
Bump go version to 1.16
89e56e3 
Since openshift/installer#5120
we need >=1.16 to build the installer from source
@hardys hardys mentioned this pull request Sep 1, 2021
Closed
@hardys hardys mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-tienne e-tienne Awaiting requested review from e-tienne

@jstuever jstuever Awaiting requested review from jstuever

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@abhinavdahiya abhinavdahiya

@patrickdillon patrickdillon

@jstuever jstuever

@Gal-Zaidman Gal-Zaidman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@eslutsky @Gal-Zaidman @patrickdillon @LorbusChris @abhinavdahiya @jstuever @openshift-merge-robot