Bug 1987848: openstack: quotas/BYON improvements #5122

EmilienM · 2021-08-02T20:14:05Z

openstack: allow to skip quota checks

Allow to skip quota checks by re-using
OPENSHIFT_INSTALL_SKIP_PREFLIGHT_VALIDATIONS variable that has been used
for validations already.
When set to 1, we'll skip quota checks. Note that this is not suggested
and please use it at your own risks.

openstack: relax quota checks to work with documented quotas

This patch was tested by QE who applied documented quota settings and successfully deployed with this patch.

This is a combined cherry-pick to make the review easier, and the overall solves a single problem related to quotas.

Due to a missing capitalization we didn't run the kuryr-specific network quota checks for OpenStack validation which could result in the installation starting even though the user has not nearly enough quota for a successful Kuryr deployment. (cherry picked from commit 5c5e29a)

Allow to skip quota checks by re-using OPENSHIFT_INSTALL_SKIP_PREFLIGHT_VALIDATIONS variable that has been used for validations already. When set to 1, we'll skip quota checks. Note that this is not suggested and please use it at your own risks. (cherry picked from commit b725c40)

When deploying OCP with pre-provisioned networks, we do not need to have available quotas for routers, networks and subnets for the machines since they are created already. This patch does the following: * On Kuryr based deployment: - Do not touch the quotas on networks / subnets, since we still need to have a bunch of quotas to create what's needed for Kuryr. - Relax the quota on Routers, since it wouldn't create one in BYON mode. * For other network types: Relax routers, subnets, networks to be 0 by default and if we don't configure OCP in BYON mode, then we add the necessary quotas (1 router, 1 network and 1 subnet). (cherry picked from commit dca1b39)

We currently document that a tenant should have ports quota set to 15 (or 1500 with Kuryr), but we didn't take in account the ports that are used for the machines: 3 masters + 3 workers = 6 ports. With these new numbers, we can deploy clusters with the existing documentation with enough resources used from available quotas. (cherry picked from commit 14b1ed0)

openshift-ci · 2021-08-02T20:14:10Z

@EmilienM: This pull request references Bugzilla bug 1989279, which is invalid:

expected dependent Bugzilla bug 1978213 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1989279: openstack: backport quotas/BYON improvements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre · 2021-08-03T06:57:20Z

/retitle Bug 1989279: openstack: quotas/BYON improvements

mandre · 2021-08-03T07:13:45Z

/retitle Bug 1987848: openstack: quotas/BYON improvements

openshift-ci · 2021-08-03T07:13:57Z

@EmilienM: This pull request references Bugzilla bug 1987848, which is invalid:

expected dependent Bugzilla bug 1987845 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1987848: openstack: quotas/BYON improvements

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre

/lgtm
/approve

patrickdillon · 2021-08-03T17:07:21Z

/approve

openshift-ci · 2021-08-03T17:07:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-03T17:11:34Z

/retest-required