IPI for vSphere w/ existing resource pool #5136

willhaines · 2021-08-05T23:24:55Z

Adds support for installing a cluster into an existing resource pool when using IPI on VMware. This allows users to take advantage of IPI on VMware with fewer cluster-wide permissions. Resolves #3921.

Heavily borrows from PR #3498. Tested manually against 4.7.0-0.okd-2021-07-03-190901 on vSphere 6.7 with (new functionality) and without (existing functionality) a resource pool. This was done by cherry-picking these commits on top of vrutkovs/installer:release-4.7-okd.

TODO:

Restructure doc/user/vsphere/privileges.md a bit to reflect permissions required when specifying an existing folder and/or resource pool, possibly without enumerating every possible combination of existing or non-existing folder and resource pool.

openshift-ci · 2021-08-05T23:25:10Z

Hi @willhaines. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2021-08-06T13:27:19Z

Thanks @willhaines for the PR!
/ok-to-test

jcpowermac · 2021-08-06T13:27:52Z

/test e2e-vsphere
/test e2e-vsphere-upi

jcpowermac · 2021-08-06T16:43:28Z

vsphere e2e failing for tests not installation related - this should be ok.

willhaines · 2021-08-10T18:30:34Z

@jcpowermac @jstuever I've now finished the doc updates that were in progress. Can either of you shine some light on which tests need to pass, and which ones are okay to fail?

jcpowermac · 2021-08-10T18:36:47Z

@willhaines need to update:
https://github.com/openshift/installer/blob/master/data/data/install.openshift.io_installconfigs.yaml#L2057-L2138
for the additional resourcepool field in the platform struct

We are also in code-freeze so this won't be merged until master is back open.

jcpowermac · 2021-08-10T19:03:39Z

@willhaines take a look at ci/prow/verify-codegen https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/5136/pull-ci-openshift-installer-master-verify-codegen/1425169319779635200

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/5136/pull-ci-openshift-installer-master-verify-codegen/1425169319779635200/build-log.txt

Any CI jobs that are marked Required will need to pass.

willhaines · 2021-08-19T19:25:09Z

/remove-work-in-progress

jcpowermac · 2021-09-29T20:46:21Z

@ayesha54 if you have time can you please review this PR

jcpowermac · 2021-09-29T20:48:30Z

pkg/terraform/exec/plugins/vsphereprivate/resource_vsphereprivate_import_ova.go

@@ -255,12 +270,16 @@ func findImportOvaParams(client *vim25.Client, datacenter, cluster, datastore, n
 		}

 		if foundDatastore && foundNetwork {
+<<<<<<< HEAD


oops ^

Sorry for all the noise. That's what I get for trying to use fancy merge tools in vscode. Should be good now.

no worries @willhaines, it happens to all of us ;-)

jcpowermac · 2021-09-29T20:58:38Z

🤞 no ci issues: openshift/release#22354

/test e2e-vsphere

/test e2e-vsphere-upi

jcpowermac · 2021-10-26T19:09:25Z

/test e2e-vsphere

/test e2e-vsphere-upi

willhaines · 2021-10-26T19:09:26Z

Rebased on master. Had to slightly tweak how the resource pool id is passed around in terraform, to fit with changes made in #5094. Sorry if rebase/force-push makes that hard to see.

jcpowermac · 2021-11-15T21:37:27Z

/remove-label do-not-merge/work-in-progress

openshift-ci · 2021-11-15T21:37:28Z

@jcpowermac: The label(s) /remove-label do-not-merge/work-in-progress cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/remove-label do-not-merge/work-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2021-11-15T21:46:05Z

/retitle [wip] IPI for vSphere w/ existing resource pool

jcpowermac · 2021-11-15T21:47:38Z

/retitle IPI for vSphere w/ existing resource pool

jcpowermac · 2021-11-15T21:48:18Z

/lgtm

jcpowermac · 2021-11-15T21:49:10Z

/assign @jstuever

jcpowermac · 2021-11-16T00:32:16Z

Both upi and ipi installed correctly. Minor test failures imho are unrelated to this pr. Still 👍 for me.

ayesha54 · 2021-11-16T14:26:13Z

@ayesha54 if you have time can you please review this PR

sure

jstuever · 2021-11-16T17:55:43Z

/approve

openshift-ci · 2021-11-16T17:56:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-11-16T18:07:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-16T18:43:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-16T18:55:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-16T19:20:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

willhaines · 2021-11-16T21:11:10Z

/test e2e-aws-upgrade

openshift-bot · 2021-11-16T22:23:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-16T22:47:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-11-17T00:50:50Z

@willhaines: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-fips	`31f42c7`	link	false	`/test e2e-aws-fips`
ci/prow/e2e-aws-workers-rhel8	`31f42c7`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-single-node	`31f42c7`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-aws-workers-rhel7	`31f42c7`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/okd-e2e-aws	`31f42c7`	link	false	`/test okd-e2e-aws`
ci/prow/okd-e2e-aws-upgrade	`31f42c7`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-crc	`31f42c7`	link	false	`/test e2e-crc`
ci/prow/e2e-vsphere-upi	`31f42c7`	link	false	`/test e2e-vsphere-upi`
ci/prow/e2e-vsphere	`31f42c7`	link	false	`/test e2e-vsphere`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-11-17T01:22:23Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-17T02:14:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2021

openshift-ci bot requested review from jcpowermac and jstuever August 5, 2021 23:25

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2021

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2021

willhaines changed the title ~~WIP: IPI for vSphere w/ existing resource pool~~ IPI for vSphere w/ existing resource pool Aug 10, 2021

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 10, 2021

willhaines force-pushed the resource-pool branch from cdaa561 to 8f690af Compare August 11, 2021 17:43

willhaines mentioned this pull request Aug 12, 2021

Enhancement necessary for resource pool support on vSphere? openshift/enhancements#868

Closed

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2021

willhaines force-pushed the resource-pool branch from 8f690af to d874f03 Compare September 29, 2021 20:43

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

jcpowermac reviewed Sep 29, 2021

View reviewed changes

willhaines force-pushed the resource-pool branch 2 times, most recently from 308ed27 to 0fc796a Compare September 29, 2021 20:51

willhaines force-pushed the resource-pool branch from 0fc796a to 9fb9cb4 Compare October 26, 2021 19:04

openshift-ci bot changed the title ~~IPI for vSphere w/ existing resource pool~~ [wip] IPI for vSphere w/ existing resource pool Nov 15, 2021

openshift-ci bot changed the title ~~[wip] IPI for vSphere w/ existing resource pool~~ IPI for vSphere w/ existing resource pool Nov 15, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2021

openshift-ci bot assigned jcpowermac Nov 15, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021

openshift-ci bot assigned jstuever Nov 15, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021

openshift-merge-robot merged commit 740cc16 into openshift:master Nov 17, 2021

staebler mentioned this pull request Jan 18, 2022

vsphere ipi ignoring resourcePool setting in install-config.yaml #5537

Closed

willhaines mentioned this pull request Mar 8, 2022

[enterprise-4.10] Issue in file installing/installing_vsphere/installing-vsphere-installer-provisioned-customizations.adoc openshift/openshift-docs#43011

Closed

IPI for vSphere w/ existing resource pool #5136

IPI for vSphere w/ existing resource pool #5136

Conversation

willhaines commented Aug 5, 2021 • edited Loading

openshift-ci bot commented Aug 5, 2021

jcpowermac commented Aug 6, 2021

jcpowermac commented Aug 6, 2021

jcpowermac commented Aug 6, 2021

willhaines commented Aug 10, 2021

jcpowermac commented Aug 10, 2021

jcpowermac commented Aug 10, 2021

willhaines commented Aug 19, 2021

jcpowermac commented Sep 29, 2021

jcpowermac Sep 29, 2021

Choose a reason for hiding this comment

willhaines Sep 29, 2021

Choose a reason for hiding this comment

jcpowermac Sep 29, 2021

Choose a reason for hiding this comment

jcpowermac commented Sep 29, 2021

jcpowermac commented Oct 26, 2021

willhaines commented Oct 26, 2021

jcpowermac commented Nov 15, 2021

openshift-ci bot commented Nov 15, 2021

jcpowermac commented Nov 15, 2021

jcpowermac commented Nov 15, 2021

jcpowermac commented Nov 15, 2021

jcpowermac commented Nov 15, 2021

jcpowermac commented Nov 16, 2021

ayesha54 commented Nov 16, 2021

jstuever commented Nov 16, 2021

openshift-ci bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

willhaines commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-bot commented Nov 16, 2021

openshift-ci bot commented Nov 17, 2021 • edited Loading

openshift-bot commented Nov 17, 2021

openshift-bot commented Nov 17, 2021

willhaines commented Aug 5, 2021 •

edited

Loading

openshift-ci bot commented Nov 17, 2021 •

edited

Loading