Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1989917: openstack: relax Security Group quotas #5140

Merged
merged 1 commit into from Aug 10, 2021

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Aug 9, 2021

OpenStack clouds deployed by Red Hat have a default security group
which contains 4 rules.

This patch will relax the number of security groups and rules so it
takes in account that a number of these resources could already be there
before installing OpenShift.

This is fine because the installer will create 2 security groups (one
for masters and one for workers, when using OpenShiftSDN, etc) and less
than 45 rules, so 56 rules is enough.
Same with Kuryr, new numbers will be enough as well.

This will allow our users following the documentation and the quotas, to
deploy on Red Hat OpenStack without modifying the quota numbers.

OpenStack clouds deployed by Red Hat have a `default` security group
which contains 4 rules.

This patch will relax the number of security groups and rules so it
takes in account that a number of these resources could already be there
before installing OpenShift.

This is fine because the installer will create 2 security groups (one
for masters and one for workers, when using OpenShiftSDN, etc) and less
than 45 rules, so 56 rules is enough.
Same with Kuryr, new numbers will be enough as well.

This will allow our users following the documentation and the quotas, to
deploy on Red Hat OpenStack without modifying the quota numbers.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2021

@EmilienM: An error was encountered searching for bug 1989917 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. could not unmarshal response body: invalid character '<' looking for beginning of value

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1989917: openstack: relax Security Group quotas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from mandre and mdbooth August 9, 2021 15:32
@EmilienM
Copy link
Member Author

EmilienM commented Aug 9, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2021

@EmilienM: An error was encountered searching for bug 1989917 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. could not unmarshal response body: invalid character '<' looking for beginning of value

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

@EmilienM: This pull request references Bugzilla bug 1989917, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 10, 2021
@openshift-ci openshift-ci bot requested a review from eurijon August 10, 2021 01:05
@pierreprinetti
Copy link
Member

/approve
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@pierreprinetti
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@pierreprinetti
Copy link
Member

Merging is blocked by openshift/release#21001

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2021

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc 4ed275c link /test e2e-crc
ci/prow/e2e-libvirt 4ed275c link /test e2e-libvirt
ci/prow/e2e-aws-single-node 4ed275c link /test e2e-aws-single-node
ci/prow/e2e-aws-workers-rhel7 4ed275c link /test e2e-aws-workers-rhel7
ci/prow/e2e-openstack-byon 4ed275c link /test e2e-openstack-byon

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

pierreprinetti commented Aug 10, 2021

/test openstack-manifests

Should succeed now that openshift/release#21001 has merged

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 3f526c4 into openshift:master Aug 10, 2021
@EmilienM EmilienM deleted the bz_1989917 branch August 10, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants